Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop testkit support for Embedded Kafka #1114

Closed
seglo opened this issue May 13, 2020 · 3 comments · Fixed by #1229
Closed

Drop testkit support for Embedded Kafka #1114

seglo opened this issue May 13, 2020 · 3 comments · Fixed by #1229
Milestone

Comments

@seglo
Copy link
Contributor

seglo commented May 13, 2020

Short description

Bundling embedded Kafka in the testkit can make it challenging to support new versions of Kafka in Alpakka Kafka as the release cycle lags Apache Kafka. When we included Embedded Kafka on the classpath it can conflict with the core Kafka client dependency and its dependency tree. Embedded Kafka with Schema Registry also relies on Confluent Platform images which typically lags the Apache Kafka release by 1-2 months and doesn't always support the same Scala versions.

Details

  • Update any remaining tests to use testcontainers instead of Embedded Kafka
  • Re-factor SerializationSpec to use testcontainers.
@seglo
Copy link
Contributor Author

seglo commented Oct 5, 2020

@ennru All that remains for this work is reorganizing docs. #1209 replaces the last of the tests that depend on embedded-kafka (except for docs snippets).

@seglo
Copy link
Contributor Author

seglo commented Oct 5, 2020

If we decide not to drop it, then I think we should at least isolate the docs snippet tests in another project so they don't interfere with the rest of the tests.

@ennru
Copy link
Member

ennru commented Oct 12, 2020

Kafka core inlines the Scala library which hinders to use Embedded Kafka with different Scala patch versions than the ones Kafka is compiled against.

This definitely decides that we drop Embedded Kafka support from the Alpakka Kafka testkit.

See #1212 and embeddedkafka/embedded-kafka#202

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants