Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop embedded-kafka testkit support #1229

Merged
merged 8 commits into from
Oct 16, 2020
Merged

Drop embedded-kafka testkit support #1229

merged 8 commits into from
Oct 16, 2020

Conversation

seglo
Copy link
Contributor

@seglo seglo commented Oct 13, 2020 •
edited
Loading

Fixes #1114

@seglo seglo force-pushed the seglo/drop-embedded-kafka branch from f610f8c to 8ae4c19 Compare October 14, 2020 21:28
@seglo
Copy link
Contributor Author

seglo commented Oct 14, 2020 •
edited
Loading

I'm having some trouble getting mima exceptions to work on the testkit. I'll look into it further tomorrow, unless someone knows what's wrong off hand.

@seglo
Copy link
Contributor Author

seglo commented Oct 14, 2020

I had the mima-filters dir in the wrong location.

@seglo seglo marked this pull request as ready for review October 14, 2020 21:33
@ennru
Copy link
Member

ennru commented Oct 15, 2020

The RetentionSpec uses Kafka-internals https://travis-ci.org/github/akka/alpakka-kafka/jobs/735859971#L353

ennru
ennru reviewed Oct 15, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you didn't notice #1230

tests/src/test/scala/akka/kafka/scaladsl/ReconnectSpec.scala Show resolved Hide resolved
testkit/src/main/java/akka/kafka/testkit/internal/AlpakkaKafkaContainer.java Show resolved Hide resolved
@seglo seglo force-pushed the seglo/drop-embedded-kafka branch from 4e590cc to a92ea49 Compare October 15, 2020 15:34
@seglo seglo marked this pull request as draft October 15, 2020 21:34
ennru
ennru approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

.scala-steward.conf Outdated Show resolved Hide resolved
testkit/src/main/java/akka/kafka/testkit/internal/AlpakkaKafkaContainer.java Show resolved Hide resolved
testkit/src/main/mima-filters/2.0.5.backwards.excludes/PR1229-drop-embedded-kafka.excludes Outdated Show resolved Hide resolved
tests/src/test/scala/akka/kafka/scaladsl/RetentionPeriodSpec.scala Outdated Show resolved Hide resolved
@seglo seglo mentioned this pull request Oct 16, 2020
Closed
@seglo seglo marked this pull request as ready for review October 16, 2020 17:06
@seglo seglo merged commit 0d9b491 into akka:master Oct 16, 2020
@seglo seglo deleted the seglo/drop-embedded-kafka branch October 16, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ennru ennru ennru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop testkit support for Embedded Kafka
2 participants
@seglo @ennru