Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testkit: enable Mima #1230

Merged
merged 1 commit into from
Oct 15, 2020
Merged

Testkit: enable Mima #1230

merged 1 commit into from
Oct 15, 2020

Conversation

ennru
Copy link
Member

@ennru ennru commented Oct 14, 2020

Even though Akka testkits do not promise binary compatibilty nor source compatibility we should use Mima to detect changes to the API.

@ennru ennru added the testkit label Oct 14, 2020
Copy link
Contributor

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Didn't get to this yesterday. I'll rebase and update the Mima changes I made in #1229.

@ennru ennru added this to the 2.1.0 milestone Oct 15, 2020
@ennru ennru merged commit e985800 into akka:master Oct 15, 2020
@ennru ennru deleted the mima-testkit branch October 15, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants