Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiscoverySupport: remove deprecation #1231

Merged
merged 3 commits into from
Oct 16, 2020
Merged

Conversation

ennru
Copy link
Member

@ennru ennru commented Oct 15, 2020

With the deprecation warning in place it became impossible to avoid it in user code without doing effort as the compiler prefers the exact type of the classic actor system.

This removes the deprecation so that a classic actor system can be passed in.

See #1209 (comment)

Copy link
Contributor

@seglo seglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

You can also remove the @SuppressWarnings("deprecation") attributes I added to ProducerSettingsTest and ConsumerSettingsTest from #1209.

@ennru ennru force-pushed the discovery-deprecation branch from 1fdca4a to b7190f1 Compare October 16, 2020 10:47
@ennru ennru merged commit 8410da4 into akka:master Oct 16, 2020
@ennru ennru deleted the discovery-deprecation branch October 16, 2020 11:35
@ennru
Copy link
Member Author

ennru commented Dec 22, 2020

This has been backported to the release-2.0.x branch to be part of 2.0.6.

@ennru
Copy link
Member Author

ennru commented Dec 22, 2020

This has been backported to the release-2.0.x branch to be part of 2.0.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants