Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add samples for creating KafkaConsumerActor for typed actor systems #984

Closed
ennru opened this issue Nov 26, 2019 · 9 comments
Closed
Milestone

Comments

@ennru
Copy link
Member

ennru commented Nov 26, 2019

The Alpakka Kafka documentation should show how the classic KafkaConsumerActor is created when the user has a typed actor system.

@johanandren
Copy link
Member

Is there something more to it than adapting the system with .toClassic ?

@ennru
Copy link
Member Author

ennru commented Dec 12, 2019

Not really, but still relevant to show, I believe.
The work is more to put that into compiling code for Alpakka Kafka docs.

@johanandren
Copy link
Member

johanandren commented Dec 12, 2019

If you update to require Akka 2.5.27 you can have the methods take an ClassicActorSystemProvider and that will make it possible to pass both typed and classic actor systems. (Or is it already 2.5.26 perhaps)

@johanandren
Copy link
Member

No, sorry, we never back ported that, scratch last comment.

@ennru
Copy link
Member Author

ennru commented Mar 9, 2020

Now that we have a module which is compiled only with Akka 2.6, this is much easier to add.

@ennru ennru added this to the 2.0.3 milestone Mar 9, 2020
@seglo
Copy link
Contributor

seglo commented Mar 9, 2020

It's a bit of a franken-module though. It's not included in the rest of the build so that it doesn't pull up Akka 2.6 deps inadvertently. Once 2.5 support is dropped it will be reintegrated, but for now the only place to add such a code example would be in the module itself, which may be fine, in the meantime.

@ennru ennru modified the milestones: 2.0.3, 2.0.4 May 14, 2020
@seglo
Copy link
Contributor

seglo commented Jul 21, 2020

Deferring until 2.1.0

@seglo seglo modified the milestones: 2.0.4, 2.1.0 Jul 21, 2020
@ennru
Copy link
Member Author

ennru commented Oct 13, 2020

Once #1209 is merged, we should review the doc examples and consider primarily showing the new actors API in the docs.

@seglo
Copy link
Contributor

seglo commented May 14, 2021

Implemented in #1370.

@seglo seglo closed this as completed May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants