Fixes #1386: set up Theme src/frontend/src/theme.js in Next #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Seneca-CDOT#1246: Syntax highlighter not working
…a-CDOT#1242) * Banner done * Side Effects Solved * Fixing DynamicImage export
…nent, and Added new frontend test script
* Changed HMSET to HSET in storage.js * updated ioredis-mock to 5.1.0 in package.json * removed comment about HMSET to HSET
Fixes Seneca-CDOT#1272: Redis link causing confusion in environment setup (Docs)
Part of Seneca-CDOT#1145: Added setup for frontend testing and Added test for Spinner component
* Add kibana to Telescope * updated env.example * added ES_HOSTS environment * proper docker-compose environment * fix * fix * removed env
…query results (Seneca-CDOT#1253) * removed unused properties * added test codes * removed unused test cases * modified some values meaningfully * moved search test to feed.test
This reverts commit cf364a6.
* Allow searching for exact phrases * removed console.log msg * removed console.log msg
replace `logger` dependency to `Console.log()/error()`
…rse img tags with data uris (Seneca-CDOT#1282) * fixes issue-1266, adds a test to ensure data URIs are sanitized properly * added two more http and https schema tests for img tag with a data uri src * added blockquote test and cite sanitation * removed irrelevant test, removed allowed attribute, and added a protocolless test. * added helpful comment regarding mixed content to img tag over http test
Issue-1409 Removed AuthorResult
…a-CDOT#1453) * Changed function name to LoadAutoScroll * Changed onScroll to onClick * Changed onClick back to onScroll
Error: Unable to parse elastic URL "http://elasticsearch:9200" and/or PORT "9200" Seneca-CDOT#1442
* Fixed logging format
Fix issue 1464: Scroll To Top button on the search page does not work on mobile version
Fix Issue1432: Mouse hover on search textField makes border disappeared
Fixed triple-reporting lint issues
Fix: specify gatsby in the path to the front-end's public folder
* Updated * removed cache * made changes for search button locations * removed public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixed #1386
Type of Change
Description
I simply added the
theme.tsfile with consideration for darkmode to be implemented in the future. At the moment, the file looks similar to thetheme.jsin Gatsby because initially we wanted to follow MUI default theme structure (more detail can be found in #1390). However, there was some concern from @humphd before about the meaning of some theme attributes that might not be as clean as we want and in PR #1414 , @abhaseen actually made a custom theme files. At the moment, the PR has not been merged so I was following the previous design. If later on, we set on a structure then we can adjust it.Checklist