-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing src attribute on img elements in posts when using data URIs #1266
Comments
Interesting, I'll have to read up about data URIs, can't say I've heard of them until now. Could I give this a shot? |
A data URI is a way of embedding a resource in the URL itself. You only use it for small items, for example, a favicon or an image. The nice thing about them is that they don't require any server storage. However, our sanitizer is filtering them out, since they don't use a secure origin. |
Assigned to you, @chrispinkney |
…s with data uris (#1282) * fixes issue-1266, adds a test to ensure data URIs are sanitized properly * added two more http and https schema tests for img tag with a data uri src * added blockquote test and cite sanitation * removed irrelevant test, removed allowed attribute, and added a protocolless test. * added helpful comment regarding mixed content to img tag over http test
…rse img tags with data uris (Seneca-CDOT#1282) * fixes issue-1266, adds a test to ensure data URIs are sanitized properly * added two more http and https schema tests for img tag with a data uri src * added blockquote test and cite sanitation * removed irrelevant test, removed allowed attribute, and added a protocolless test. * added helpful comment regarding mixed content to img tag over http test
I notice a post today that is missing images. The
<img>
element is there, but it has nosrc
attribute:The original post does have them: https://palak-chawla.blogspot.com/2020/10/release-02-pr-4.html, but they are using Data URIs:
The text was updated successfully, but these errors were encountered: