Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: specify gatsby in the path to the front-end's public folder #1475

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

manekenpix
Copy link
Member

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This fixes the path the public folder when served by the backend (locally, it doesn't affect dev or prod),
This only shows up when running telescope only using docker, or when trying to access the front-end using port 3000 instead of 8000.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@manekenpix manekenpix self-assigned this Dec 2, 2020
@manekenpix manekenpix changed the title fix: specify gatsby in the path to the front-end's public folder Fix: specify gatsby in the path to the front-end's public folder Dec 2, 2020
@manekenpix manekenpix merged commit 2ca6bc4 into Seneca-CDOT:master Dec 2, 2020
@manekenpix manekenpix deleted the fix-frontend-path branch March 16, 2021 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 min fix Fixable in 5 minutes or less area: back-end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants