Error: Unable to parse elastic URL "http://elasticsearch:9200" and/or PORT "9200" #1442

[zg3d]

Issue This PR Addresses

#1442

Type of Change

• Bugfix: Change which fixes an issue
• New Feature: Change which adds functionality
• Documentation Update: Change which improves documentation
• UI: Change which improves UI

Description

Tested the docker build and it was succes full

Checklist

• Quality: This PR builds and passes our npm test and works locally
• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
• Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

[humphd]

Nice, a few things I see.

[humphd]

Awesome, great work. One tip on the way you're writing these tests. You have 6 variables at the top of the describe block that are shared between all the tests. This isn't a great pattern, and you'd be better off moving all of these into the test functions that use them (maximum isolation between tests, no dependencies, etc).

In your case this isn't going to break, since you used const with strings; but if you had non-immutable types (e.g., object references) this could be problematic, if one test updated the data before another used it.

[humphd]

Tagging @c3ho since he needs this fix for #1450.

[c3ho]

I don't know if its me, but I can't get telescope to work with docker-compose up --build Telescope keeps crashing on Windows 10. I can confirm ElasticSearch is working now, but I can't say the same for Telescope

[humphd]

@c3ho what's in the log file it generated?

[c3ho]

One of the earlier runs:

Terminal message in the most recent run:

I wiped docker images prior to testing this and still doesn't work. Maybe my elastic container is taking too long to start and Telescope crashes from it?

If I run the command docker-compose up redis elasticsearch + npm start separately, it will work, but docker-compose up --build fails.

[humphd]

Or maybe this PR isn't parsing the URL in your env correctly? What are you using for env with these elasitic params?

[c3ho]

Should it matter though? I thought we're overwriting it with the docker-compose envs when we run docker-compose up --build?

It's weird because obviously it is working since it passes the CI checks on github.

Edit: Elasticsearch works, but Telescope crashes before Elasticsearch is fully up and running.

[manekenpix]

@c3ho change ELASTIC_DELAY_MS in your .env file, give it more time. The same was happening to me and the problem was that it was taking ES more than ELASTIC_DELAY_MS to be ready to store posts.

[c3ho]

Got it to work after @manekenpix suggestion.