Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure current theme.js to follow MUI theme structure. #1390

Closed
tonyvugithub opened this issue Nov 18, 2020 · 0 comments · Fixed by #1397
Closed

restructure current theme.js to follow MUI theme structure. #1390

tonyvugithub opened this issue Nov 18, 2020 · 0 comments · Fixed by #1397
Assignees
Labels
type: enhancement New feature or request

Comments

@tonyvugithub
Copy link
Contributor

tonyvugithub commented Nov 18, 2020

What would you like to be added:
A matching theming attributes to MUI default theme structure
Change our current theming from ...

const theme = createMuiTheme({
  palette: {
    primary: {
      main: '#333E64',
    },
    secondary: {
      main: '#0589D6',
    },
    error: {
      main: red.A400,
    },
    background: {
      default: '#E5E5E5',
    },
    text: {
      primary: '#E5E5E5',
      secondary: '#8BC2EB',
      default: '#181818',
    },
  },
});

to Something similar to the following...

image

Luckily it seems that we only have a conflict in text attribute, there is no default key in text
Why would you like this to be added:
This will help with Typescript when we migrate to Nextjs and allow light/dark mode switching easily

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant