Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 489 #1254

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Issue 489 #1254

merged 3 commits into from
Oct 29, 2020

Conversation

zg3d
Copy link
Contributor

@zg3d zg3d commented Oct 29, 2020 •
edited by c3ho
Loading

Issue This PR Addresses

Fixes #489

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@c3ho c3ho requested a review from manekenpix October 29, 2020 21:30
c3ho
c3ho previously approved these changes Oct 29, 2020
View reviewed changes
humphd
humphd requested changes Oct 29, 2020
View reviewed changes
src/backend/utils/storage.js Outdated Show resolved Hide resolved
@humphd humphd merged commit 8513a45 into Seneca-CDOT:master Oct 29, 2020
@humphd
Copy link
Contributor

humphd commented Oct 29, 2020

Hey @mskuybeda, we did it! It took nearly a year, but your fixes are finally wired into Telescope thanks to @zg3d.

@zg3d zg3d deleted the issue-489 branch October 29, 2020 23:10
manekenpix pushed a commit to manekenpix/telescope that referenced this pull request Nov 11, 2020
@zg3d
Issue 489 (Seneca-CDOT#1254)
7ae3d9a 
* Changed HMSET to HSET in storage.js

* updated ioredis-mock to 5.1.0 in package.json

* removed comment about HMSET to HSET
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humphd humphd humphd approved these changes

@c3ho c3ho c3ho left review comments

@manekenpix manekenpix Awaiting requested review from manekenpix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace HMSET to HSET when becomes avaliable
3 participants
@zg3d @humphd @c3ho