Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace HMSET to HSET when becomes avaliable #489

Closed
mskuybeda opened this issue Dec 7, 2019 · 4 comments · Fixed by #1254
Closed

Replace HMSET to HSET when becomes avaliable #489

mskuybeda opened this issue Dec 7, 2019 · 4 comments · Fixed by #1254
Labels
area: back-end area: redis Redis Database related good first issue Good for newcomers type: enhancement New feature or request type: nice to have Feature that'd be nice to have, but not a priority

Comments

@mskuybeda
Copy link
Contributor

What would you like to be added:
Replace HMSET with HSET in storage.js and storage.test.js

Why would you like this to be added:
HMSET is deprecated as of now and is replaced with HSET. I was not able to use HSET originally since it was not implemented in neither ioredis nor mock-redis.

I have implemented the functionality of HSET into ioredis, please refer HERE

However, redis-mock as of 2019-12-07 is being reviewed. Refer to my PR and Issue .
@mskuybeda mskuybeda added type: enhancement New feature or request area: back-end area: redis Redis Database related labels Dec 7, 2019
@humphd humphd added the Blocked Can't do this, until something else is done label Jan 20, 2020
@humphd
Copy link
Contributor

humphd commented Jan 20, 2020

This is still blocked on stipsan/ioredis-mock#898.

@humphd humphd added the type: nice to have Feature that'd be nice to have, but not a priority label Apr 1, 2020
@humphd
Copy link
Contributor

humphd commented Oct 28, 2020

Fixed in stipsan/ioredis-mock#1007, we can pull in ioredis 5.1.0 to get this I think (needs to be tested).

@manekenpix
Copy link
Member

All tests passed using ioredis-mock 5.1.0 and using HSET in storage.js.

@manekenpix manekenpix added good first issue Good for newcomers and removed Blocked Can't do this, until something else is done labels Oct 29, 2020
@zg3d
Copy link
Contributor

zg3d commented Oct 29, 2020

Can I try to do this issue.

@zg3d zg3d mentioned this issue Oct 29, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: back-end area: redis Redis Database related good first issue Good for newcomers type: enhancement New feature or request type: nice to have Feature that'd be nice to have, but not a priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue 489
5 participants
@humphd @manekenpix @zg3d @mskuybeda @lozinska