Fix #1008: HSET is replacing HMSET #1012
Conversation
|
About checks not passed, I am not sure why, but issues rise in the files I did not touch. Could you please check what is going on |
| }); | ||
| }); | ||
| }); | ||
| it("should affect the old way", function(done) { |
There was a problem hiding this comment.
I guess you mean "should not" here.
There was a problem hiding this comment.
Well, the whole point was to make hset act the same way as hmset. According to documentation.
|
Thank you for the contribution. The tests are failed. Could you fix it please? |
|
Failed tests are in master and not in the files I changed. I will take a look into what causes them, but I am not sure I will have time to fix them this week at least. Probably will file another issue. I forgot to remove logs, my bad. I will work on the stated changes a bit later today. Thanks for your reply. |
|
@mskuybeda You're right. I did a quick look and created a fix. Please rebase the latest commit on the master branch. |
mskuybeda
force-pushed
the
issue-1008
branch
from
53a3cf8 to
aa7e21b
Compare
|
Cherry-picked to the master branch. Thank you for the contribution! |
I have added functionality to ioredis to support HSET the same way as HMSET. Please Review