-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1225 - Reposition search button for search UI #1474
Conversation
@jossiey I figured out how I added cache. |
I think you added the |
def2d7f
to
140b4e4
Compare
@manekenpix I have no idea how I put that there, but it is removed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well.
I found one small issue: we need to deal with the button overlapping longer search text input; but I'm going to file it as a follow-up so as to not block this further.
Filed #1476 on adornment overlap of input text. |
Issue This PR Addresses
Fixes #1225
Type of Change
Description
Moved search button down to the right of the search bar
Checklist