Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1225 - Reposition search button for search UI #1474

Merged
merged 4 commits into from
Dec 2, 2020

Conversation

strawberries73
Copy link
Contributor

Issue This PR Addresses

Fixes #1225

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Moved search button down to the right of the search bar
image

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@strawberries73
Copy link
Contributor Author

@jossiey I figured out how I added cache.

@manekenpix
Copy link
Member

I think you added the public folder inside of the front-end to this PR.

@strawberries73
Copy link
Contributor Author

@manekenpix I have no idea how I put that there, but it is removed now.

Copy link
Contributor

@Jasper-Mui Jasper-Mui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works well.

I found one small issue: we need to deal with the button overlapping longer search text input; but I'm going to file it as a follow-up so as to not block this further.

@humphd
Copy link
Contributor

humphd commented Dec 2, 2020

Filed #1476 on adornment overlap of input text.

@humphd humphd merged commit 9412aa4 into Seneca-CDOT:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reposition search button for search UI
4 participants