Backports for 1.0.4 #30536
Closed
Backports for 1.0.4 #30536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit f49cb42)
(cherry picked from commit 891e2ab)
(cherry picked from commit dda6450)
(cherry picked from commit 99b7b75)
(cherry picked from commit c379900)
(cherry picked from commit 072ad7d)
The manual mentions at https://docs.julialang.org/en/v1/manual/environment-variables/#JULIA_WORKER_TIMEOUT-1 a function Base.worker_timeout() but the implementation has instead only a function Distributed.worker_timeout() (cherry picked from commit 258e08a)
(cherry picked from commit 6dc205a)
This fixes a corner case where a bug is caused, counter-intuitively, by an over-estimated intersection. We have method signatures A and B, with A<B (A is a strict subtype). We have a dispatch tuple X, where X<:B and !(X<:A). However, intersection returns X for intersect(X,A). Since there appears to be a match there and A<B, ml_matches skips the match with B. The fix just requires dispatch tuples to be a subtype of a signature in order to match at all. (cherry picked from commit b167bc2)
* kill workers which don't launch properly * don't emit spurious error messages * document how to asynchronously launch workers (cherry picked from commit 121e814)
|
I have a few backports not yet tagged. Can I still get them in? |
|
Of course, there is no hurry with 1.0.4. |
KristofferC
force-pushed
the
backport-1.0.4
branch
from
f47a4f4
to
a27dd86
Compare
* Remove unused struct CapturedScalars * Fix method ambiguities in SparseArrays * Fix HigherOrderFns._copy(f) (cherry picked from commit f10530e)
KristofferC
force-pushed
the
backport-1.0.4
branch
from
a27dd86
to
fb28ab4
Compare
Use the same pattern as in collect_to_with_first! (which is used when size is known). (cherry picked from commit 184fbc4)
The last attempts were pretty good, but still missed a lot. But this is what you find when you actually try to test it. This is not too important, but it can reduce compilation performance in some case, so it is not ideal. (cherry picked from commit 76e7421)
This corresponds to macOS 10.12 Sierra. XCode 8 covers El Capitan and Sierra, so if Travis is giving us XCode 8.x for x < 3, we're on El Cap. Homebrew supports only three versions of macOS at a time, which means that El Cap (10.11) is no longer support. This is likely why our Mac builds are trying to build GCC from source; a bottle might not be available. (cherry picked from commit 862fe08)
(cherry picked from commit a25945a)
* implement circshift! for SparseMatrixCSC * factor helper function shifter!, implement efficient circshift! for SparseVector * add some @inbounds for improved performance * remove allocations completely, giving a large improvement for small matrices * some renaming to avoid polluting the module namespace * remove useless reallocation and fix bug with different in/out types, better tests * avoid action if iszero(r) and/or iszero(c), move sparse vector shifting helpers to sparsevector.jl * Make shift amounts deterministic in tests, move sparse vector tests into sparsevector.jl * comment fix * for some reason, copy!(a::SparseVector, b::SparseVector) does not work (cherry picked from commit 94993e9)
SROA was accidentally treating a pending node as old and thus getting the wrong type when querying the predecessor. As a result it thought one of the paths was unreachable causing undefined data to be introduced on that path (generally the `1.0` that happened to already be in register). Fix #29983 (cherry picked from commit da0179c)
I don't have concrete tests for these, but it looks like they all need the `is_old` predicate for what they're doing, so switch those over also while we're at it. (cherry picked from commit 34f7a4a)
Clarify that `firstindex(str)` should always be `1` for any `AbstractString`, as mentioned by @StefanKarpinski [here](#26133 (comment)). Also reference `prevind` and `eachindex`. Also introduce the "code unit" terminology and mention the `codeunit` functions. (cherry picked from commit 3b6773d)
(cherry picked from commit 8b45c9c)
PR #28478 moved the computation of the use counts before the finish call. to fix #28444. However, the early parts of the finish call fixes up phi node arguments, which fail to get counted if we look at use counts before that fixup is performed. This causes #30594 where the only non-trivial use is on the backedge of the phi and would thus incorrectly fail to get accounted for. Fix that by taking the use count after phi fixup but before dce. (cherry picked from commit f8f2045)
|
We changed a bunch of backport labels in the last triage call so this is pretty stale. Better to restart from scratch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
showonSymbol#30303, escaping $ when showing SymbolsJL_AArch64_crcinstead ofHWCAP_CRC32#30324 - UseJL_AArch64_crcinstead ofHWCAP_CRC32@inboundsannotations for filter #30156 -@inboundsannotations for filter_similar_for#30331 - Force specialization on the type argument of_similar_forlambda-optimize-vars!with complex assignment RHSs #30564 - fixlambda-optimize-vars!with complex assignment RHSsNeed manual backport:
_applymatch the implementation more closely #30483 - make inference of_applymatch the implementation more closelyreturn_type#30470 - use type inference world inreturn_typeContains multiple commits, manual intervention needed:
bb-installnaming conventions, add hashes #30535 - Fixbb-installnaming conventions, add hashesNon-merged PRs with backport label: