Dev-doc updates for the SSAIR section #30622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKarpinski
added
backport 1.1
status:triage
|
Bump. |
StefanKarpinski
removed
status:triage
|
No need to triage and we don't backport docs. |
This mainly fixes typos. Note that I think the `foo` function on line 114 is wrong. It errors when run (`y` not defined), and it doesn't match the IR shown below it (there's no `bar` function for example). I don't have a fix for that.
KristofferC
pushed a commit
that referenced
this pull request
Apr 11, 2020
* Dev-doc updates for the SSAIR section This mainly fixes typos. Note that I think the `foo` function on line 114 is wrong. It errors when run (`y` not defined), and it doesn't match the IR shown below it (there's no `bar` function for example). I don't have a fix for that. * Fix foo example Co-authored-by: Keno Fischer <keno@alumni.harvard.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mainly fixes typos.
Note that I think the
foofunction on line 114 is wrong. It errors when run (ynot defined), and it doesn't match the IR shown below it (there's nobarfunction for example). I don't have a fix for that.