cluster manager fixes #30172
Merged
cluster manager fixes #30172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amitmurthy could you please review? thanks. |
|
This looks okay, but it would be good to have a test |
bjarthur
force-pushed
the
bja/launchworkers
branch
from
10de262
to
433a17a
Compare
|
@amitmurthy may not be watching. |
|
Why don't we just remove "failed" from julia/stdlib/Distributed/src/cluster.jl Line 301 in a50d5af |
amitmurthy
reviewed
Nov 29, 2018
bjarthur
force-pushed
the
bja/launchworkers
branch
2 times, most recently
from
7592ab8
to
ef52319
Compare
|
lastly, i've added documentation as to how to asynchronously launch workers. it'd be great if this PR could be reviewed again. thanks for the previous comments. much better now. |
vchuravy
approved these changes
Dec 21, 2018
amitmurthy
reviewed
Dec 21, 2018
bjarthur
force-pushed
the
bja/launchworkers
branch
2 times, most recently
from
b8aa79f
to
271e501
Compare
bjarthur
force-pushed
the
bja/launchworkers
branch
from
271e501
to
e47a65e
Compare
|
LGTM |
staticfloat
pushed a commit
that referenced
this pull request
Dec 30, 2018
* kill workers which don't launch properly * don't emit spurious error messages * document how to asynchronously launch workers
KristofferC
pushed a commit
that referenced
this pull request
Dec 30, 2018
* kill workers which don't launch properly * don't emit spurious error messages * document how to asynchronously launch workers (cherry picked from commit 121e814)
|
thanks! @amitmurthy could you please review the related JuliaParallel/ClusterManagers.jl#74 too? |
staticfloat
pushed a commit
that referenced
this pull request
Jan 4, 2019
* kill workers which don't launch properly * don't emit spurious error messages * document how to asynchronously launch workers
StefanKarpinski
added
status:triage
JeffBezanson
removed
backport 1.0
status:triage
|
We can backport this to 1.0 if it's critical for somebody's cluster environment, but for now we won't plan to. |
Keno
pushed a commit
that referenced
this pull request
Jun 5, 2024
* kill workers which don't launch properly * don't emit spurious error messages * document how to asynchronously launch workers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30031
the two commit messages say it all.
i'll happily add a third commit to fix the REPL being blocked during worker startup if someone gives me a hint as to what to change. this is a problem when the remote worker ends up in the pending queue on a busy cluster. in julia 0.6 the remote workers were launched in the background. i've tried making a few changed to the various
@asyncsthat are sprinked through the relevant code, but nothing has worked so far.