fix #30303, escaping $ when showing Symbols (#30304)

* fix #30303, escaping $ when showing Symbols * use repr instead of escape_string
JuliaLang · Dec 8, 2018 · f0b9499 · f0b9499 · nanosoldier · Dec 8, 2018
1 parent 4fc446f
commit f0b9499
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/base/show.jl b/base/show.jl
@@ -1031,7 +1031,7 @@ function show_unquoted_quote_expr(io::IO, @nospecialize(value), indent::Int, pre
             print(io, ":")
             print(io, value)
         else
-            print(io, "Symbol(\"", escape_string(s), "\")")
+            print(io, "Symbol(", repr(s), ")")
         end
     else
         if isa(value,Expr) && value.head === :block

diff --git a/test/show.jl b/test/show.jl
@@ -1416,3 +1416,6 @@ end
 replstrcolor(x) = sprint((io, x) -> show(IOContext(io, :limit => true, :color => true),
                                          MIME("text/plain"), x), x)
 @test occursin("\e[", replstrcolor(`curl abc`))
+
+# issue #30303
+@test repr(Symbol("a\$")) == "Symbol(\"a\\\$\")"