Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom deserialize method for UmfpackLU to avoid memory leak #30425

Merged
merged 1 commit into from
Jan 2, 2019

Conversation

andreasnoack
Copy link
Member

Fixes #15450

I'm not sure what would be a good way to test this. Can I compare some of the values from the GC output before and after running

foreach(1:10000) do i
    seekstart(b)
    serialize(b, F)
    seekstart(b)
    SuiteSparse.UMFPACK.umfpack_symbolic!(deserialize(b))
end

Which of the gc values would be appropriate to compare?

@andreasnoack andreasnoack added domain:arrays:sparse Sparse arrays kind:bugfix This change fixes an existing bug backport pending 1.0 labels Dec 17, 2018
@ViralBShah
Copy link
Member

Do we have to do it for all the factorizations in SuiteSparse?

@fredrikekre
Copy link
Member

You will have to add Serialization to SuiteSparse/Project.toml as a dependency.

@KristofferC KristofferC mentioned this pull request Dec 20, 2018
52 tasks
@andreasnoack andreasnoack added the needs tests Unit tests are required for this change label Dec 28, 2018
@KristofferC KristofferC mentioned this pull request Dec 30, 2018
53 tasks
@andreasnoack andreasnoack removed the needs tests Unit tests are required for this change label Jan 2, 2019
@andreasnoack andreasnoack merged commit 356ceee into master Jan 2, 2019
@andreasnoack andreasnoack deleted the an/umfpackleak branch January 2, 2019 20:06
KristofferC pushed a commit that referenced this pull request Jan 11, 2019
@StefanKarpinski StefanKarpinski added status:triage This should be discussed on a triage call backport 1.0 and removed status:triage This should be discussed on a triage call backport 1.0 labels Jan 31, 2019
@StefanKarpinski StefanKarpinski added the status:triage This should be discussed on a triage call label Jan 31, 2019
@JeffBezanson JeffBezanson removed status:triage This should be discussed on a triage call triage backport pending 1.0 labels Jan 31, 2019
KristofferC pushed a commit that referenced this pull request Feb 4, 2019
@KristofferC KristofferC mentioned this pull request Feb 4, 2019
39 tasks
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
KristofferC pushed a commit that referenced this pull request Apr 20, 2019
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:arrays:sparse Sparse arrays kind:bugfix This change fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parallel LU factorization memory leak
6 participants