Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in string search api docs #30600

Merged
merged 2 commits into from
Jan 6, 2019
Merged

Conversation

ashleysommer
Copy link
Contributor

@ashleysommer ashleysommer commented Jan 5, 2019

findlast cannot be called with 3 arguments, (with the third being a a start index), this should read findprev(

findlast cannot be called with 3 arguments, (with the third being a a start index), this is mean to read `findprev(`
@ararslan ararslan added domain:docs This change adds or pertains to documentation domain:strings "Strings!" labels Jan 5, 2019
Copy link
Member

@ararslan ararslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

base/strings/search.jl Outdated Show resolved Hide resolved
Change variable name in example from `s` to `string` to match the signature on the lines above it.

Co-Authored-By: ashleysommer <ashleysommer@gmail.com>
@fredrikekre
Copy link
Member

Thanks, and welcome as a contributor!

@fredrikekre fredrikekre merged commit a25945a into JuliaLang:master Jan 6, 2019
KristofferC pushed a commit that referenced this pull request Jan 11, 2019
@KristofferC KristofferC mentioned this pull request Jan 11, 2019
53 tasks
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@KristofferC KristofferC mentioned this pull request Feb 11, 2019
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:docs This change adds or pertains to documentation domain:strings "Strings!"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants