Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generalize sparse matrix slicing to integer types #30319

Merged
merged 1 commit into from
Dec 20, 2018
Merged

generalize sparse matrix slicing to integer types #30319

merged 1 commit into from
Dec 20, 2018

Conversation

dpo
Copy link
Contributor

@dpo dpo commented Dec 8, 2018

There is a discussion leading to this pull request on Discourse: https://discourse.julialang.org/t/missing-method-to-slice-sparse-matrices/18430

@ViralBShah ViralBShah added the domain:arrays:sparse Sparse arrays label Dec 20, 2018
@ViralBShah ViralBShah merged commit 072ad7d into JuliaLang:master Dec 20, 2018
KristofferC pushed a commit that referenced this pull request Dec 20, 2018
@dpo @KristofferC
generalize sparse matrix slicing to integer types (#30319)
5125952 
(cherry picked from commit 072ad7d)
@KristofferC KristofferC mentioned this pull request Dec 20, 2018
Merged
52 tasks
KristofferC pushed a commit that referenced this pull request Dec 30, 2018
@dpo @KristofferC
generalize sparse matrix slicing to integer types (#30319)
3c9592d 
(cherry picked from commit 072ad7d)
@KristofferC KristofferC mentioned this pull request Dec 30, 2018
Closed
53 tasks
@KristofferC
Copy link
Sponsor Member

This was already backported to 1.1.0

@StefanKarpinski StefanKarpinski added status:triage This should be discussed on a triage call backport 1.0 and removed status:triage This should be discussed on a triage call labels Jan 31, 2019
@JeffBezanson JeffBezanson removed status:triage This should be discussed on a triage call triage backport pending 1.0 labels Jan 31, 2019
KristofferC pushed a commit that referenced this pull request Feb 4, 2019
@dpo @KristofferC
generalize sparse matrix slicing to integer types (#30319)
db270b7 
(cherry picked from commit 072ad7d)
@KristofferC KristofferC mentioned this pull request Feb 4, 2019
Merged
39 tasks
KristofferC pushed a commit that referenced this pull request Feb 11, 2019
@dpo @KristofferC
generalize sparse matrix slicing to integer types (#30319)
7a58bfd 
(cherry picked from commit 072ad7d)
KristofferC pushed a commit that referenced this pull request Apr 20, 2019
@dpo @KristofferC
generalize sparse matrix slicing to integer types (#30319)
4148b76 
(cherry picked from commit 072ad7d)
@KristofferC KristofferC added the kind:bugfix This change fixes an existing bug label May 16, 2019
@KristofferC KristofferC mentioned this pull request Aug 26, 2019
Merged
55 tasks
KristofferC pushed a commit that referenced this pull request Feb 20, 2020
@dpo @KristofferC
generalize sparse matrix slicing to integer types (#30319)
e37c2d0 
(cherry picked from commit 072ad7d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
domain:arrays:sparse Sparse arrays kind:bugfix This change fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dpo @KristofferC @StefanKarpinski @ViralBShah @JeffBezanson