WIP: Backports for 1.0.5 #33075
Merged
WIP: Backports for 1.0.5 #33075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
added
needs nanosoldier run
(cherry picked from commit 7cbeb3d)
Copy meta nodes from IRCode to CodeInfo (cherry picked from commit 5168e35)
points to the last non-opt argument of argv, but in the case where there are only options optind does not go beyond argc, except on musl libc, where it becomes argc + 1. (cherry picked from commit 9de07ce)
…2 SSL. (cherry picked from commit b317206)
Shows the `Dates.format` table which was the behaviour in the Julia 0.6 documentation. (cherry picked from commit 826bb8b)
This restricts the element type of the input vector to be `<:Real` and only converts in case the promoted type is concrete. Fixes #32092. (cherry picked from commit 587cb82)
This example reproduces the issue observed in issue 32092 on Julia 1.1 that was fixed by PR 32097. (cherry picked from commit 6da7aa8)
* readdlm(bytearray) shouldn't modify bytearray * Update stdlib/DelimitedFiles/src/DelimitedFiles.jl Co-Authored-By: Jeff Bezanson <jeff.bezanson@gmail.com> (cherry picked from commit 7038210)
* fixes for getindex tab-completion * test fix (cherry picked from commit 1eca37e)
(cherry picked from commit 85603e1)
This fix adapts the fast path from UInt32(::Char) to the case of digit parsing. (cherry picked from commit 510db13)
Statistics uses Random in its tests but doesn't declare it as a test dependency in its Project.toml. (cherry picked from commit f6049d6)
This avoids a regression (correctness and performance) caused by #21262 where we were no longer able to fold away the isnull assertion in the case where the source also contains an explicit isassigned check. Also upgrade many other CreateInBoundsGEP calls to include the element type (NFC). (cherry picked from commit a7427aa)
The last return statement is currently referring to a non-existent s variable. Also fix the related doctest, even though it does not get tested at the moment. (cherry picked from commit 7bda2c1)
The bug here is a bit subtle, but perhaps best illustrated with
the included test case:
```
function f32579(x::Int64, b::Bool)
if b
x = nothing
end
if isa(x, Int64)
y = x
else
y = x
end
if isa(y, Nothing)
z = y
else
z = y
end
return z === nothing
end
```
The code just after SSA conversion looks like:
```
2 1 ─ goto #3 if not _3
3 2 ─ %2 = Main.nothing::Core.Compiler.Const(nothing, false)
5 3 ┄ %3 = φ (#2 => %2, #1 => _2)::Union{Nothing, Int64}
│ %4 = (%3 isa Main.Int64)::Bool
└── goto #5 if not %4
6 4 ─ %6 = π (%3, Int64)
└── goto #6
8 5 ─ %8 = π (%3, Nothing)
10 6 ┄ %9 = φ (#4 => %6, #5 => %8)::Union{Nothing, Int64}
│ %10 = (%9 isa Main.Nothing)::Bool
└── goto #8 if not %10
11 7 ─ %12 = π (%9, Nothing)
└── goto #9
13 8 ─ %14 = π (%9, Int64)
15 9 ┄ %15 = φ (#7 => %12, #8 => %14)::Union{Nothing, Int64}
│ %16 = (%15 === Main.nothing)::Bool
└── return %16
```
Now, we have special code in SROA (despite it not really being an
SROA transform) that looks at `===` and replaces
it by a nest of phis of booleans. The reasoning for this transform
is that it eliminates a use of a value where we only care about the
type and not the content, thus making it more likely that the value
will subsequently be eligible for SROA. In addition, while it goes
along resolving which values feed into any particular phi, it
accumulates and type conditions it encounters along the way.
Thus in the example above, something like the following happens:
- We look at %14, which πs to %9 with an Int64 constraint, so we only
consider the #4 predecessor for %9 (due to the constraint), until
we get to %3, where we again only consider the #1 predecessor,
where we find the argument (of type Int64) and conclude the result
is always false
- Now we pop the next item of the stack from our original phi, look
at %12, which πs to %9 with a Nothing constraint.
At this point we used to terminate the search because we already looked
at %9. However, crucially, we looked at %9 only with an Int64 constraint,
so we missed the fact that `nothing` was in fact a possible value for this
phi. The result was a missing entry in the generated phi node:
```
1 ─ goto #3 if not b
2 ─ %2 = Main.nothing::Core.Compiler.Const(nothing, false)
3 ┄ %3 = φ (#1 => false)::Bool
│ %4 = φ (#2 => %2, #1 => _2)::Union{Nothing, Int64}
│ %5 = (%4 isa Main.Int64)::Bool
└── goto #5 if not %5
4 ─ %7 = π (%4, Int64)
└── goto #6
5 ─ %9 = π (%4, Nothing)
6 ┄ %10 = φ (#4 => %3, #5 => %3)::Bool
│ %11 = φ (#4 => %7, #5 => %9)::Union{Nothing, Int64}
│ %12 = (%11 isa Main.Nothing)::Bool
└── goto #8 if not %12
7 ─ goto #9
8 ─ nothing::Nothing
9 ┄ %16 = φ (#7 => %10, #8 => %10)::Bool
└── return %16
```
(note the missing #2 predecessor in phi node %3), which would result
in an undefined value at runtime, though in this case LLVM would
have taken advantage of that to just return 0:
```
define i8 @julia_f32579_16051(i64, i8) {
top:
; @ REPL[1]:15 within `f32579'
ret i8 0
}
```
Compare this now to the optimized IR with this patch:
```
1 ─ goto #3 if not b
2 ─ %2 = Main.nothing::Core.Compiler.Const(nothing, false)
3 ┄ %3 = φ (#2 => true, #1 => false)::Bool
│ %4 = φ (#2 => %2, #1 => _2)::Union{Nothing, Int64}
│ %5 = (%4 isa Main.Int64)::Bool
└── goto #5 if not %5
4 ─ %7 = π (%4, Int64)
└── goto #6
5 ─ %9 = π (%4, Nothing)
6 ┄ %10 = φ (#4 => %3, #5 => %3)::Bool
│ %11 = φ (#4 => %7, #5 => %9)::Union{Nothing, Int64}
│ %12 = (%11 isa Main.Nothing)::Bool
└── goto #8 if not %12
7 ─ goto #9
8 ─ nothing::Nothing
9 ┄ %16 = φ (#7 => %10, #8 => %10)::Bool
└── return %16
```
The %3 phi node has its missing entry and the generated LLVM code
correctly returns `b`:
```
define i8 @julia_f32579_16112(i64, i8) {
top:
%2 = and i8 %1, 1
; @ REPL[1]:15 within `f32579'
ret i8 %2
}
```
(cherry picked from commit 0a12944)
* [Statistics] fix type determination in corm * remove obsolete typeof * use first element(s) for type initialization * add test for inhomogeneous data and for overflow * fix test with NaN (cherry picked from commit a8a567e)
* fix generic ldiv! for CholeskyPivoted * add back one empty line to make backport easier * don't interfere with previous tests (cherry picked from commit d0e11cf)
(cherry picked from commit 25eb8c6)
(cherry picked from commit 30b3636)
KristofferC
force-pushed
the
backports-release-1.0
branch
from
dabdea5 to
36ba4f3
Compare
Using `futimes` and passing NULL for the `times` parameter sets the current and access file times, but does not require file ownwership. From man page: > If times is NULL, the access and modification times are set to the current time. The caller must be the owner of the file, have permission to write the file, or be the superuser. (cherry picked from commit 3b3a163)
|
@nanosoldier |
|
This backport PR already has too many commits so I suggest we check if the current set of commits are good and then tag a 1.0.5 based on that. The rest can go in 1.0.6. |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
|
PkgEval: https://gist.github.com/KristofferC/013907eb3c201547009fd34d104fb187
Everything passes locally except for Reactive seems to be a tol error |
(cherry picked from commit bcca250)
* Fix incorrect sign in atanh In the case that x==-1, we have to flip the sign of ξ. * Formatting: Add space after comma Co-Authored-By: cafaxo <cafaxo@gmail.com> * Add test * Do not drop sign of zero * Flip sign to avoid a DomainError This fixes atanh(prevfloat(-1.0) + 0im) * Test all four combinations Co-Authored-By: cafaxo <cafaxo@gmail.com> * Tests for expressions that were signed incorrectly * Use the correct type for 1 * Update doc * Update doc: Remove trailing whitespace (cherry picked from commit 66341a3)
KristofferC
force-pushed
the
backports-release-1.0
branch
from
ec7c6f6 to
cad5fc6
Compare
KristofferC
removed
the
needs nanosoldier run
KristofferC
force-pushed
the
backports-release-1.0
branch
from
cad5fc6 to
fc33508
Compare
(cherry picked from commit 07c2ecc)
KristofferC
force-pushed
the
backports-release-1.0
branch
from
fc33508 to
b717256
Compare
ararslan
removed
DO NOT MERGE
vchuravy
pushed a commit
to JuliaLang/Distributed.jl
that referenced
this pull request
Oct 6, 2023
…ease-1.0 Backports for 1.0.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported PRs:
cpon files >2GB #30989 - fix cp(file,file-copy) broken for >2GB files #14574,cpon files >2GBisafast path for typevars with lower bounds #32040 - fixisafast path for typevars with lower boundsimport Distributed; Distributed.@everywhere x = 2does not work #28966.=== nothingis not== nothingwith--code-coverage=user#32579 - Issue in typeconstraint accumulationNeed manual backport:
reprto show arbitrary objects in error messages #30700 - fixvec[nothing]fails to print its error message #30633, usereprto show arbitrary objects in error messageslet#32326 - fix Defining a struct with an outer constructor in local scope gives bad error #32325, struct plus outer ctor insideletforinsidedoinside call #32476 - fix Parsing issue when using threads macro #32467, parsing macro onforinsidedoinside callContains multiple commits, manual intervention needed:
Non-merged PRs with backport label: