Fix tryparse for invalid Chars #32351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix adapts the fast path from UInt32(::Char) to the case of digit parsing.
c42f
force-pushed
the
cjf/tryparse-fix-invalid-char-error
branch
from
68a0ab3
to
c9a7871
Compare
|
CI failures seem to be unrelated network and multiprocess problems. |
|
Well, given #32314 (comment) I think I'll merge this. |
KristofferC
pushed a commit
that referenced
this pull request
Jul 1, 2019
This fix adapts the fast path from UInt32(::Char) to the case of digit parsing. (cherry picked from commit 510db13)
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
This fix adapts the fast path from UInt32(::Char) to the case of digit parsing. (cherry picked from commit 510db13)
55 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
This fix adapts the fast path from UInt32(::Char) to the case of digit parsing. (cherry picked from commit 510db13)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
This fix adapts the fast path from UInt32(::Char) to the case of digit parsing. (cherry picked from commit 510db13)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix adapts the fast path from UInt32(::Char) to the case of digit parsing.
Fixes #32314