fixes for getindex tab-completion #31499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis is failing with an apparently unrelated error |
|
For Travis: #31500 |
stevengj
force-pushed
the
fixgetindexunicode
branch
from
aca0f05 to
d0e5c07
Compare
|
Bump. Rebase? Let's get this merged. |
stevengj
force-pushed
the
fixgetindexunicode
branch
from
d0e5c07 to
235f7d0
Compare
|
Rebased. |
|
Fails test: |
stevengj
force-pushed
the
fixgetindexunicode
branch
from
235f7d0 to
b03c9f6
Compare
|
Should be fixed now. |
|
Tests are green except for unrelated ```failed process: Process(`curl```` on Windows. Should be good to merge? |
JeffBezanson
pushed a commit
that referenced
this pull request
Jun 21, 2019
* fixes for getindex tab-completion * test fix (cherry picked from commit 1eca37e)
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
* fixes for getindex tab-completion * test fix (cherry picked from commit 1eca37e)
55 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
* fixes for getindex tab-completion * test fix (cherry picked from commit 1eca37e)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
* fixes for getindex tab-completion * test fix (cherry picked from commit 1eca37e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24705. Closes #25094 by @Jutho, which this replaces (I didn't preserve the commit history, sorry — rebasing an old PR was too much trouble for such a short patch).
Also fixes
dict[to tab-complete to a list of all the keys, rather than a list of allMain.*symbols, and fixes a couple of Unicode indexing bugs.