Add missing test dependency on Random to Statistics #32383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Statistics uses Random in its tests but doesn't declare it as a test dependency in its Project.toml.
fredrikekre
approved these changes
Jun 21, 2019
|
Doesn't seem to be needed on 1.0. |
Should still probably be applied, because even if it doesn't cause an error in Pkg, Statistics is still using Random without declaring a test dependency on it. |
|
Strange, tests pass on 1.0.3 etc though... |
KristofferC
pushed a commit
that referenced
this pull request
Jul 1, 2019
Statistics uses Random in its tests but doesn't declare it as a test dependency in its Project.toml. (cherry picked from commit f6049d6)
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
Statistics uses Random in its tests but doesn't declare it as a test dependency in its Project.toml. (cherry picked from commit f6049d6)
55 tasks
KristofferC
pushed a commit
that referenced
this pull request
Aug 26, 2019
Statistics uses Random in its tests but doesn't declare it as a test dependency in its Project.toml. (cherry picked from commit f6049d6)
KristofferC
pushed a commit
that referenced
this pull request
Feb 20, 2020
Statistics uses Random in its tests but doesn't declare it as a test dependency in its Project.toml. (cherry picked from commit f6049d6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Statistics uses Random in its tests but doesn't declare it as a test dependency in its Project.toml. Because of this, Statistics fails in the PkgEval 1.2.0-rc2 run. (But oddly enough not for 1.1.1.) Backporting this should fix that.
I'm also marking it for backport to 1.0, because the issue exists there, PkgEval just doesn't seem to complain about it for 1.0.