Deploy Checklist: New Expensify 2024-04-10

[github-actions]

Release Version: 1.4.62-17
Compare Changes: production...staging

This release contains changes from the following pull requests:

• Enable Fabric and TurboModules on iOS & Android #13767
• Remove unnecessary calls to OpenPrivatePersonalDetailsPage #37047
• Remove Save the World from Global Create, and move it into Settings #37175
• [TS migration] Migrate 'ReimbursementAccount' page to TypeScript #37214
• [TS migration] Migrate 'EmojiPicker' component to TypeScript #37641
• #37927 bugfix: member details issues #37961
• QBO import main page #38400
• [Reassure] Add measureFunction test for formatSectionsFromSearchTerm  #38551
• Clear the task report when it's failed to create #38730
• [TS migration] Migrate 'Sidebar' page to TypeScript #38947
• Fix For Spacing Around Toggle Buttons  #39031
• fix: Focus not removed when selection list changes. #39141
• [TS migration] Migrate StepScreenWrapper, StepScreenDragAndDropWrapper, IOURequestStepConfirmation and IOURequestStepCategory pages to TypeScript #39175
• Track distance expenses #39190
• 39061 adjust virtual viewport with smart app banner #39209
• fix: regression: 39083, 39178 #39226
• feat: Expense Tracking in the Workspace Chat #39239
• fix: When amount is highlighted, clicking on the page does not deselect the text #39311
• fix: new task created when editing task assignee #39328
• fix(38312): Update dependencies as indicated by Snyk #39372
• Update currency for StartSplitBill #39373
• Fix: Send a message button in Expensify Help is not working #39387
• [NoQA] feat: chat TTI #39394
• Update thread headers and ancestry to deep link back to the original comment using comment linking #39454
• Migrate deprecated pronouns #39522
• fix user can proceed without start button #39553
• Remove IOUCurrencySelection.js and copy any changes since Nov 27 into IOURequestStepCurrency.js  #39562
• [TS migration] Migrate withFullTransactionOrNotFound HOC to TypeScript #39582
• fix: Tags & Categories - Name row in item RHP is not grayed out when edited offline #39584
• Fix header displays skeleton when creating report with invalid user #39585
• [Snyk] Security upgrade electron from 29.0.0 to 29.2.0 #39586
• Fix: VisionCamera macro autofocus not working on iOS  #39589
• Split the performance test workflow to two github workflows #39594
• Fix missing checkmark next to Total amount after paying request while offline #39604
• Show personal bank account option when sending money #39619
• Update redirects.csv #39627
• Fix policy change log message #39643
• update stripe ACH originator name #39651
• Feat: implement accounting page  #39652
• Delete docs/articles/expensify-classic/reports/Currency.md #39664
• Publish Expense-Types.md under Expenses category #39666
• Delete docs/articles/expensify-classic/reports/Expense-Types.md #39667
• Publish The-Expenses-Page.md in the Expenses category #39669
• Disable pay button when the expense report currency is different than workspace currency #39684
• [Audit][Implementation] - Use only supported locales to reduce the APK size #39688
• fix: user is navigated back to same iou #39723
• Delete docs/articles/expensify-classic/expensify-billing/Annual-Subsc… #39740
• Delete docs/articles/expensify-classic/expensify-billing/Billing-Owne… #39744
• Delete docs/articles/expensify-classic/expensify-billing/Pay-Per-Use-… #39747
• Delete docs/articles/expensify-classic/expensify-billing/Individual-S… #39749
• Rename SAML-SSO.md to SAML-SSO.md #39761
• Fix user can skip legal name form in workspace bank account page #39786
• Don't add report screen by default when visiting RHP in narrow layout #39788
• Fix: error msg only download link is clickable #39789
• Fix editing distance in one transaction report page navigates the user to transaction thread #39801
• Update redirects.csv to fix broken link for export options #39826
• [No QA] Check for undefined in promiseWhile.ts #39830
• Fix: IOU Request scan camera not displaying when permission first given #39854
• Use macos-13-large runners for desktop builds #39860
• Fix: Not here page shows up when opening tax with special characters #39893
• Update redirects.csv #39897
• Fix: skip flaky reassure tests #39901
• fix: Incorrect handling of GBR for Admin #39941
• [No QA] Adding check if the current client is the active one on OnyxUpdates #39943
• Update redirects.csv #39948
• [NoQA] Skip [ReportScreen] should press of the report item #39952
• Fix onboarding video progress bar #39964
• Add check if client is active before applying pusher updates #39990
• feat: bump @react-navigation/stack #40008
• [CP Staging] Fix tax amount error #40049
• [CP Staging] Fix: treat only Expense and IOU reports as one-transaction ones #40079
• Remove unneeded condition for Send Money/Request distance #40096
• [CP Staging] Comment the QR code download button until it can be fixed #40109
• Follow up to "Update thread headers ancestry to deep link back to the original comment" #40155
• [CP Staging] fix: Blank page after returning to IOU report from thread and deleting the other request #40157
• fix: unable click currency tax amount when editing #40159
• Remove all request de-duping logic #40180
• Unpausing the queue when we receive Pusher updates while we're still loading the App #40184
• [CP Staging] feat: change new arch flash list to interop #40191
• 40076 update adjust viewport #40201
• [CP Staging] Fixed isAllowedToSplit condition #40239
• [CP Staging] fix: remove sensor animation for now #40302
• [CP Staging] Fix: iOS - Thread - Unable to send a message after returning from thread - ParentNavigationSubtitle - Update navigation method to go back instead of navigate #40315
• [CP Staging] Fix: Workspace - Deleting a message on Announce room takes user to another report page #40368
• Revert "[CP Staging] feat: change new arch flash list to interop" #40383
• [CP Staging][No QA] Temporarily disable Android production deploys #40391

Deploy Blockers:

• [HOLD for payment 2024-05-09] [$250] [DEV]User invited by mentioning from a concierge whisper can't see parent message #39982
• [HOLD for payment 2024-04-25] Chat - Not here page shows up when deleting message after returning from thread #40027
• [$250] Track expense - Chat shows skeleton after the second track expense with receipt is created #40028
• Track expense - Track distance expense does not show up in self DM #40029
• [$250] Android - Account settings - Account settings page flickers if scrolled down when switching #40034
• Web - Accounting - Multiple functions in the Accounting page are non responsive #40035
• [HOLD for payment 2024-04-25] Tax - Maximum tax amount is 0 error msg on updating currency for non-default tax rate #40036
• [$500] Thread - Message sent after returning from thread is not shown after refreshing the page #40037
• [$250] Track expense -Track distance preview in self DM does not show green thumbnail in offline mode #40039
• [HOLD for payment 2024-04-25] Android - Chat - Composer is not responsive after tapping on the composer #40040
• [HOLD E/App #38072] [$250] Storybook - Storybook is displaying a white page upon opening + console errors #40041
• CRITICAL: [Actionable Whispers] Incorrect amount in paid message in LHN when there is tracking and request #40042
• [HOLD #40266] Track - LHN and expense preview show incorrect info when there is tracking and request #40043
• Track expense - Total changes to 0.00 when deleting manual request and leaving only trackings #40045
• Track expense - Empty preview shows up in the main chat after deleting the tracking #40047
• [HOLD for payment 2024-05-03] [$1000] Android - LHN - Unable to open reports, tasks and threads in LHN #40048
• Task - When returning from task, yellow highlight is visible #40050
• Android - The error message "Hmm... it's not here" appeared twice #40052
• Chat-In compose box, emojis displayed are cut off in top. #40053
• [HOLD for payment 2024-04-25] Android - IOU - Unable to send money with user having no prior conversation #40055
• [$250] Android - Sign out - App flickers when signing out #40056
• [HOLD for payment 2024-04-25] iOS - Thread - Unable to send a message after returning from thread #40057
• [HOLD for payment 2024-04-25] Deleting a tracked expense hides all tracked expense #40067
• [HOLD for payment 2024-04-25] Chat - Previous messages jump continuously when opening the native emoji keyboard #40076
• [HOLD for payment 2024-04-25] [$500] iOS - Wallet - Bank button is not responsive #40077
• [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [$500] IOU-After deleting request, hold request system message displayed distorted #40078
• [$250] WS - Profile - Share - Workspace QR code is not downloaded to the device #40080
• [Hold for payment] [2024-04-30][$250] Bank account - Random animations between steps transitions on bank account setup flow #40081
• [ON HOLD PAYMENT 4/29][$250] BA - Missing "Routing number" and "Account number" title after revisiting Bank info page #40082
• Save the world - Back button opens Save the world page with chat LHN instead of menu list #40084
• [HOLD][$250] Task - App scrolls to the top after returning from task report when there is IOU & task #40085
• [Awaiting payment][$125] Web - Workspace - Console error shows up when clicking Share button #40086
• [HOLD for payment 2024-04-25] [$250] IOU - Blank page after returning to IOU report from thread and deleting the other request #40087
• [$250] iOS - Chat - Inconsistency in sending attachments offline when you come back online. #40093
• [HOLD for payment 2024-06-06] [$250] Android - Distance - Waypoint does not change position correctly by dragging #40105
• Android - Chat - Keyboard not immediately disappeared when tapped on plus button or navigated to LHN #40107
• [$1000] Android - Unable to access popup menu while "New message" marker is visible #40108
• [HOLD for payment 2024-04-25] [$250] Tax - Not here page opens when clicking currency in tax amount in transaction thread #40123
• iOS - Distance - Recent destination list animation is not smooth or seamless #40124
• [HOLD for payment 2024-05-20] iOS - Wallet - Missing up and down key and Done button in the header of account selection list #40126
• [HOLD for payment 2024-04-25] Split option is showing up in the Send money flow #40242
• [HOLD for payment 2024-04-25] Workspace - Deleting a message on "Announce" room takes user to another report page #40343
• [$250] iOS - Chat - Emojis are not displayed properly in the emoji picker #40360
• [$250] Clicking into a thread and out disappears message below the parent message #40376

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[Julesssss]

Checked off as they don't need to be QA'd:

• Delete docs/articles/expensify-classic/expensify-billing/Annual-Subsc… #39740
• Delete docs/articles/expensify-classic/expensify-billing/Billing-Owne… #39744
• Delete docs/articles/expensify-classic/expensify-billing/Pay-Per-Use-… #39747
• Delete docs/articles/expensify-classic/expensify-billing/Individual-S… #39749

[kavimuru]

Checking off the PROD PRs (help.expensify.com)
#39387
#39664
#39666
#39667
#39669
#39826

[blimpich]

Demoting #40027

[roryabraham]

#40050 is intended behavior

[Julesssss]

#40082 is not a blocker
#39982 is not a blocker
#40052 is not a blocker

[twisterdotcom]

Closed #40093

[Julesssss]

#40053 is minor and related to a new feature (live-markdown)
#40086 is a console log, demoted

[Julesssss]

#40085 demoted as not critical

[Julesssss]

#40067
and #40029 fixed by this CP: #40079

[Julesssss]

#40036 fixed by #40049

[kavimuru]

Regression is 3% left.
#38730 failing with #40103
#38947 failing with #40048
#39190 failing with #40029
#39239 failing with #40043
#39372 failing with #40041
#39723 failing with #40051 repro in PROD, checking it off
#39788 failing with #40052

[Beamanator]

Checked off #40081 as it doesn't seem like a big enough issue to be a blocker

[Julesssss]

#40055 fixed by #40096

[luacmartins]

Demoted #40126

[deetergp]

Demoted #40035

[kavimuru]

Regression is just 14 steps left.
Unchecked PRs:
#39394 we need more details about the QA steps and not sure it is internal. Comment
#38730 failing with #40103
#38947 failing with #40048
#39190 failing with #40029
#39239 failing with #40043
#39372 failing with #40041
#39454 failing with #40108
#39562 failing with #40036
#39788 failing with #40052

[kavimuru]

Regression is completed.
Unchecked PRs:
#39394 we need more details about the QA steps and not sure it is internal. Comment
#38730 failing with #40103
#38947 failing with #40048
#39190 failing with #40029
#39239 failing with #40043
#39372 failing with #40041
#39454 failing with #40108
#39562 failing with #40036
#39788 failing with #40052
Open Blockers:
#40034
#40037
#40040
#40041
#40048
#40057
#40076
#40077
#40078
#40084
#40087
#40105
#40107
#40108
#40123
#40124

[rlinoz]

Demoting #40105

[Beamanator]

This CP'd PR fixed #40080, both are checked off the list now

[roryabraham]

confirmed #40077 is fixed, checking it off

[roryabraham]

ok, so we've been talking through this checklist in #fireroom-2024-04-17-app-deploy. Ultimately it has not gone very smoothly, and that's largely due to inconsistently reproducible but critical issues that have happened in concert with enabling the new architecture.

Our plan is to ship this release on all platforms except Android, where we're aware of a number of unresolved critical issues. This will allow us to continue shipping code on all other platforms and prevent the monster release that will follow this one from growing any more cumbersome than it already promises to be.

[roryabraham]

#40360 is fixed by #40383 in 1.4.62-15 (without re-introducing #40077)

[roryabraham]

#40048 and #40108 share the same root cause, and remain unresolved. These are Android-only issues, and as mentioned above I'm going to check them off. They will continue to have the deploy blocker label, so should appear as deploy blockers in the next checklist

[thienlnam]

There's only one fresh crash
SensorSetter.sensorSetter

Fatal Exception: com.facebook.jni.CppException
Exception in HostFunction: Error: Exception in HostFunction: at _maybeFlushUIUpdatesQueue (native) at anonymous (JavaScript:1:405) at callMicrotasksOnUIThread (JavaScript:1:61) at anonymous (JavaScript:1:406)

com.swmansion.reanimated.nativeProxy.SensorSetter.sensorSetter (SensorSetter.java)

It's only happened to a single user on 1.4.62-7 so I think we're okay here -

[thienlnam]