-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Fix: treat only Expense and IOU reports as one-transaction ones #40079
[CP Staging] Fix: treat only Expense and IOU reports as one-transaction ones #40079
Conversation
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Only the Android recording is missing, building it now... |
Assigning @shubham1206agra from the original PR |
Screen.Recording.2024-04-11.at.1.11.10.PM.movWeird behavior when going back. |
This is some weird comment linking behavior. In prod, clicking the link in the header leads just to the parent report. On Staging, it leads to the linked parent report action (check the URL). I would dig into that direction, but it's not related to this PR. |
@paultsimura Can you mark #40029 as fixed issue too? |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariScreen.Recording.2024-04-11.at.1.17.17.PM.movMacOS: Chrome / SafariScreen.Recording.2024-04-11.at.1.17.17.PM.movMacOS: Desktop |
@roryabraham This might be related to comment linking. #40079 (comment) |
Co-authored-by: Monil Bhavsar <monilbhavsar25@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
[CP Staging] Fix: treat only Expense and IOU reports as one-transaction ones (cherry picked from commit c5b84fd)
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀
|
Details
Fixed Issues
$ #40067, #40029
PROPOSAL: N/A
Tests
Same as QA
Offline tests
Same as QA
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
chrome08.48.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-11.at.08.41.1708.48.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-04-11.at.08.42.2608.48.mp4
MacOS: Chrome / Safari
Screen.Recording.2024-04-11.at.08.36.4408.39.mp4
MacOS: Desktop
Screen.Recording.2024-04-11.at.08.39.1408.39.mp4