-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD #40266] Track - LHN and expense preview show incorrect info when there is tracking and request #40043
Comments
Triggered auto assignment to @Christinadobrzyn ( |
Triggered auto assignment to @neil-marcellini ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Not a blocker as this is a new feature related to track |
@thienlnam FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
We think this bug might be related to #wave-collect - Release 1 |
This might be related to BE. |
I can recreate with the steps in the OP. @neil-marcellini can you check to see if this needs to be Interal or External? |
I'm fixing some other report total calculations in https://github.com/Expensify/Auth/pull/10494, which may actually also end up fixing this bug |
Cool thanks Jack. I'm going to mark it internal and assign it over to you for now. We might need frontend changes too but I'll wait until you determine that after the backend PRs. If you need to and there are more changes required, you can re-assign me. |
Job added to Upwork: https://www.upwork.com/jobs/~017264c636107b6770 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @jayeshmangwani ( |
Why was this one put in #wave-collect? |
Ah sorry @trjExpensify I though this was wave collect since it deals with expenses and not just chat. I'll review the initiatives again to make sure I'm on the right page. thanks for moving it over. |
@thienlnam, @jayeshmangwani, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Tying together with #40266 |
Held on #40266 |
monitoring - #40266 |
I'm going to move this to weekly since it will be combined with #40266 Let me know if you think this should stay daily - @thienlnam |
Should be resolved now |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue found when validating #39239
Version Number: 1.4.62-0
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
In Step 5, after creating the second track manual expense, the LHN preview will show the total amount of the report.
In Step 7, the expense preview will show "3 requests".
Actual Result:
In Step 5, after creating the second track manual expense, the LHN preview only shows the amount of second track expense.
In Step 7. the expense preview shows the merchant of the first request.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6445053_1712779682530.20240411_035725.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: