Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD #40266] Track - LHN and expense preview show incorrect info when there is tracking and request #40043

Closed
6 tasks done
m-natarajan opened this issue Apr 10, 2024 · 20 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Apr 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when validating #39239
Version Number: 1.4.62-0
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat with no request history.
  3. Create a track manual expense ($10) with merchant A > click Track Expense (to create the expense)
  4. Create a $5 manual request (not track expense) with merchant B > click the Request button (to create the expense)
  5. Create a second track manual expense ($5) with merchant C > click Track Expense (to create the expense)
  6. Click on the expense preview.
  7. Return to the main workspace chat.

Expected Result:

In Step 5, after creating the second track manual expense, the LHN preview will show the total amount of the report.
In Step 7, the expense preview will show "3 requests".

Actual Result:

In Step 5, after creating the second track manual expense, the LHN preview only shows the amount of second track expense.
In Step 7. the expense preview shows the merchant of the first request.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6445053_1712779682530.20240411_035725.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~017264c636107b6770
  • Upwork Job ID: 1778474804893405184
  • Last Price Increase: 2024-04-11
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 10, 2024
@thienlnam
Copy link
Contributor

Not a blocker as this is a new feature related to track

@m-natarajan
Copy link
Author

@thienlnam FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@m-natarajan
Copy link
Author

We think this bug might be related to #wave-collect - Release 1

@shubham1206agra
Copy link
Contributor

This might be related to BE.

@Christinadobrzyn
Copy link
Contributor

I can recreate with the steps in the OP. @neil-marcellini can you check to see if this needs to be Interal or External?

@thienlnam
Copy link
Contributor

I'm fixing some other report total calculations in https://github.com/Expensify/Auth/pull/10494, which may actually also end up fixing this bug

@neil-marcellini
Copy link
Contributor

Cool thanks Jack. I'm going to mark it internal and assign it over to you for now. We might need frontend changes too but I'll wait until you determine that after the backend PRs.

If you need to and there are more changes required, you can re-assign me.

@neil-marcellini neil-marcellini added the Internal Requires API changes or must be handled by Expensify staff label Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

Job added to Upwork: https://www.upwork.com/jobs/~017264c636107b6770

Copy link

melvin-bot bot commented Apr 11, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @jayeshmangwani (Internal)

@trjExpensify
Copy link
Contributor

Why was this one put in #wave-collect? Track expense is a #vip-vsb initiative.

@Christinadobrzyn
Copy link
Contributor

Ah sorry @trjExpensify I though this was wave collect since it deals with expenses and not just chat. I'll review the initiatives again to make sure I'm on the right page. thanks for moving it over.

@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
Copy link

melvin-bot bot commented Apr 15, 2024

@thienlnam, @jayeshmangwani, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!

@thienlnam
Copy link
Contributor

Tying together with #40266

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Apr 16, 2024
@thienlnam thienlnam changed the title Track - LHN and expense preview show incorrect info when there is tracking and request [HOLD #40266] Track - LHN and expense preview show incorrect info when there is tracking and request Apr 18, 2024
@thienlnam
Copy link
Contributor

Held on #40266

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2024
@Christinadobrzyn
Copy link
Contributor

monitoring - #40266

@Christinadobrzyn
Copy link
Contributor

I'm going to move this to weekly since it will be combined with #40266

Let me know if you think this should stay daily - @thienlnam

@Christinadobrzyn Christinadobrzyn added Weekly KSv2 and removed Daily KSv2 labels Apr 24, 2024
@thienlnam
Copy link
Contributor

Should be resolved now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants