-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show personal bank account option when sending money #39619
Show personal bank account option when sending money #39619
Conversation
@bernhardoj Can you merge main again to see if it fixes the perf test? |
Merged with main |
@bernhardoj I'm having an issue if I have a bank account that's not fully set up (additional details required). Once I tap desktop-chrome-midway-bank-2024-04-05_14.14.30.mp4 |
@jjcoffee do you have any personal bank account added already? If yes, delete it first. The popover menu will show if you don't have a bank account yet. App/src/components/KYCWall/BaseKYCWall.tsx Lines 172 to 176 in 2995f2c
If it still happens, then it's probably another bug. Try to switch to another account. |
Looks like there are multiple error coming from main |
@bernhardoj I have a partially set-up personal bank account (the additional details required screen popped up after adding it but I wasn't able to complete it because of another bug 😄). I guess it makes sense to open straight to the additional details screen in this case. |
Remerging main should fix the ts error. |
Done |
@bernhardoj Do you have a personal bank account added? I can't get one added at the moment, so would be good to know the flow works all the way (money successfully sends, essentially!). |
Reviewer Checklist
Screenshots/VideosAndroid: Nativeandroid-app-2024-04-05_14.22.45.mp4Android: mWeb Chromeandroid-chrome-2024-04-05_14.25.00.mp4iOS: Nativeios-app-2024-04-05_14.18.04.mp4iOS: mWeb Safariios-safari-2024-04-05_14.19.22.mp4MacOS: Chrome / Safaridesktop-chrome-2024-04-05_14.06.08.mp4MacOS: Desktopdesktop-app-2024-04-05_14.17.32.mp4 |
@jjcoffee I think adding the personal bank account from the plaid can be done, but it's the KYC that I can't pass through. |
@bernhardoj Yeah I have the same! I guess it shouldn't be related to this PR anyway, just hoped to have a complete test all the way through. I think we're good to skip it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.62-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.62-0 🚀
|
🚀 Deployed to staging by https://github.com/arosiclair in version: 1.4.62-0 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀
|
Details
We want to show personal bank account option when sending money to user.
Fixed Issues
$ #38739
PROPOSAL: #38739 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-04-04.at.23.26.00.mov
Android: mWeb Chrome
Screen.Recording.2024-04-04.at.23.28.45.mov
iOS: Native
Screen.Recording.2024-04-04.at.23.15.31.mov
iOS: mWeb Safari
Screen.Recording.2024-04-04.at.23.25.15.mov
MacOS: Chrome / Safari
Screen.Recording.2024-04-04.at.23.23.31.mov
MacOS: Desktop
Screen.Recording.2024-04-04.at.23.10.47.mov