Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track expense - Total changes to 0.00 when deleting manual request and leaving only trackings #40045

Closed
6 tasks done
m-natarajan opened this issue Apr 10, 2024 · 19 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Apr 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.62-0
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat with no request history.
  3. Create a track manual expense.
  4. Create a manual request (not track expense).
  5. Create a second track manual expense.
  6. Click on the expense preview.
  7. Delete the manual request in Step 4.

Expected Result:

The total amount will update accordingly after deleting the manual request and leaving only track expenses.

Actual Result:

The total amount changes to 0.00 and it only shows the correct total after revisiting the report.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6445101_1712781251437.20240411_042940.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f9bcc46c20d53fb1
  • Upwork Job ID: 1778840188915064832
  • Last Price Increase: 2024-04-12
@m-natarajan m-natarajan added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @jasperhuangg (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Apr 10, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@m-natarajan
Copy link
Author

@garrettmknight FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@m-natarajan
Copy link
Author

We think this bug might be related to #wave-collect - Release 1

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Apr 10, 2024
@thienlnam thienlnam assigned thienlnam and unassigned jasperhuangg Apr 10, 2024
@thienlnam
Copy link
Contributor

Not a blocker, part of new feature of Track. This is also related to #40042 regarding the BE using the total not just reimbursable total

@garrettmknight
Copy link
Contributor

@thienlnam shall we hold on that issue then?

@garrettmknight garrettmknight changed the title Track expense - Total changes to 0.00 when deleting manual request and leaving only trackings [HOLD on #40042] Track expense - Total changes to 0.00 when deleting manual request and leaving only trackings Apr 12, 2024
@garrettmknight garrettmknight added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff and removed Daily KSv2 labels Apr 12, 2024
Copy link

melvin-bot bot commented Apr 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01f9bcc46c20d53fb1

Copy link

melvin-bot bot commented Apr 12, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @paultsimura (Internal)

@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@garrettmknight
Copy link
Contributor

Still held on #40042

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 30, 2024
@garrettmknight garrettmknight changed the title [HOLD on #40042] Track expense - Total changes to 0.00 when deleting manual request and leaving only trackings Track expense - Total changes to 0.00 when deleting manual request and leaving only trackings Apr 30, 2024
@garrettmknight garrettmknight added Daily KSv2 and removed Weekly KSv2 labels Apr 30, 2024
@melvin-bot melvin-bot bot removed the Overdue label Apr 30, 2024
@garrettmknight
Copy link
Contributor

Off hold - moving to daily to test.

@garrettmknight garrettmknight removed their assignment May 3, 2024
@garrettmknight garrettmknight added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels May 3, 2024
Copy link

melvin-bot bot commented May 3, 2024

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@garrettmknight
Copy link
Contributor

@twisterdotcom - I didn't get to retest this and I'm taking off for a few days. Can you test and close if it's fixed?

@twisterdotcom
Copy link
Contributor

Ah god, okay. I'm also off next week but I'll try to squeeze this in.

@twisterdotcom
Copy link
Contributor

I am sorry, I did not get to reset this. Going to add retest label and we'll get QA to do it. We can close if they confirm it's not happening.

@twisterdotcom twisterdotcom added the retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause label May 3, 2024
@melvin-bot melvin-bot bot added the Overdue label May 6, 2024
Copy link

melvin-bot bot commented May 7, 2024

@twisterdotcom, @paultsimura, @thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

1 similar comment
Copy link

melvin-bot bot commented May 7, 2024

@twisterdotcom, @paultsimura, @thienlnam Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@thienlnam thienlnam added Weekly KSv2 and removed Daily KSv2 labels May 8, 2024
@melvin-bot melvin-bot bot removed the Overdue label May 8, 2024
@thienlnam
Copy link
Contributor

Pending retest

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

7 participants