39061 adjust virtual viewport with smart app banner #39209
Conversation
melvin-bot
bot
requested review from
sobitneupane
and removed request for
a team
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@situchan could you please review this PR? |
|
@situchan is on leave this month. So, I think I should review the PR. It might take a while for me to go through previous proposal and PR. |
|
@sobitneupane please review. Thx |
|
@suneox Can you please help me understand what changes in your previous PR caused the issue? And how your new PR will solve the issue? |
| useEffect(() => addViewportResizeListener(updateOffsetTop), [shouldAdjustScrollView, updateOffsetTop]); | ||
|
|
||
| useEffect(() => { | ||
| setTimeout(() => { |
There was a problem hiding this comment.
@suneox use of setTimeout is discouraged.
…l-viewport-with-smart-app-banner
Hi @sobitneupane, Let me clear, The previous PR to fix an issue when the keyboard changes size on mWeb/Safari the virtual offset top don't update so the header and composer will be overlap. My PR is to adjust the scroll view and offset the top based on the initial viewport height when the toggle change keyboard height at this lines and another change check specific use case to avoid regression But when run on a real device we have a config for a smart app banner at In this PR instead of using viewport height has a delay when navigating between another screen to set an initial height, I have changed to using Here is a result on a real device with a smart app banner Before fix RPReplay_Final1712602327.MP4After fix RPReplay_Final1712601749.MP4 |
|
Thanks for the explanation and the update @suneox Changes look good. But I can still reproduce the issue (though not consistently). Untitled.mp4
|
hi @sobitneupane the issue you mentioned also happened sometimes on production when quickly navigating between screens before my PR deploy and I also confirmed at this comment Could you please view
|
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
|
@suneox Since this issue was not resulted by your previous PR, I am approving this. Can you please report the issue in slack though? |
Yes I'll raise this issue after this PR deploy due to currently an issue can not reproduce |
src/pages/home/ReportScreen.tsx
Outdated
| @@ -275,7 +275,8 @@ function ReportScreen({ | |||
| Performance.markStart(CONST.TIMING.CHAT_RENDER); | |||
| } | |||
| const [isComposerFocus, setIsComposerFocus] = useState(false); | |||
| const viewportOffsetTop = useViewportOffsetTop(Browser.isMobileSafari() && isComposerFocus && !modal?.willAlertModalBecomeVisible); | |||
| const shouldAdjustScrollView = useMemo(() => Browser.isMobileSafari() && isComposerFocus && !modal?.willAlertModalBecomeVisible, [isComposerFocus, modal]); | |||
There was a problem hiding this comment.
index.ts is only a web file (since there is also an index.native.ts), which means that the Browser.isMobileSafari() shouldn't really be here. I think this browser check should be moved inside of index.ts so that the logic is better incapsulated. The browser check should be coupled with an early return.
There was a problem hiding this comment.
Yes we should move Browser.isMobileSafari() into index.ts and I have updated
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/tgolen in version: 1.4.62-0 🚀
|
1 similar comment
|
🚀 Deployed to staging by https://github.com/tgolen in version: 1.4.62-0 🚀
|
|
🚀 Deployed to staging by https://github.com/tgolen in version: 1.4.62-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.62-17 🚀
|
Details
Fixed Issues
$ #39061
PROPOSAL: #39061 (comment)
Tests
Preconditions
On dev mode we have to config show the smart app banner and test on real ios device
Add a meta data into web/index.html
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
iOS: Native
Screen.Recording.2024-03-29.at.00.48.24.mov
iOS: mWeb Safari
Real device
RPReplay_Final1711648700.MP4
Simulator
Screen.Recording.2024-03-29.at.00.46.08.mov
Android: Native
Uploading Screen Recording 2024-03-29 at 00.54.34.mov…
Android: mWeb Chrome
Screen.Recording.2024-03-29.at.00.52.29.mov
MacOS: Chrome / Safari
Screen.Recording.2024-03-29.at.00.33.33.mov
MacOS: Desktop
Screen.Recording.2024-03-29.at.00.35.43.mov