[HOLD for payment 2024-04-25] [$500] Chat - Compose Box is shown above empty space and doesn't resize properly

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.57-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4459664
Email or phone of affected tester (no customers): gatantm@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to any chat
2. Tap on the compose box
3. Type a few lines and tap on expand icon

Expected Result:

The compose box is directly above the keyboard, expands with the first few lines added and expands to half the screen when tapping the expand icon

Actual Result:

The compose box has empty space between it and the keyboard, expands with the first few lines but either doesn't expand when tapping the expand icon or contracts.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6428664_1711543443184.RPReplay_Final1711543166.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013eedeeb058661915
• Upwork Job ID: 1772998191642521600
• Last Price Increase: 2024-03-27
• Automatic offers:
• suneox | Contributor | 0

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tgolen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@JmillsExpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #vip-vsb.

[izarutskaya]

Production video

RPReplay_Final1711548176.MP4

[JmillsExpensify]

@tgolen Do you think this is a blocker? I agree with QA that it's a #vip-vsb issue, though I also think this is largely cosmetic.

[tgolen]

It is a pretty ugly bug, but since it doesn't prevent any functionality and only affects a single platform, I agree it's not a blocker. Let's make this a normal bug and I'll see if I can quickly spot the PR that might have caused the regression. I'll remove the deploy blocker label for now.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013eedeeb058661915

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[tgolen]

@suneox Do you think this might have been a regression of your recent PR #38755 ?

[suneox]

@suneox Do you think this might have been a regression of your recent PR #38755 ?

Let me find offending PR due to on my PR this issue doesn't happens

[suneox]

@tgolen could you please give me the current branch has been deployed to staging, I can't reproduce on latest main with simulator and real device

trim.0615238D-F6A8-4722-A4E4-565B1F74EFDE.MOV

trim.AC294377-885B-4605-AD15-CDFE55456288.MOV

[tgolen]

OK, thank you for reporting that. I think it's fine to not include a fix for that in your PR. There have been known issues with mWeb and the smart app banner for a long time.

[suneox]

PR is ready for review

[sobitneupane]

Regression from #35380 issue #38755 PR. @situchan will be reviewing the PR.

[sobitneupane]

@situchan is on leave this month. So, I think I should go ahead and review the PR.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• 39061 adjust virtual viewport with smart app banner #39209

If no regressions arise, payment will be issued on 2024-04-25. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Contributor)
• @sobitneupane requires payment through NewDot Manual Requests

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@JmillsExpensify, @tgolen, @suneox, @sobitneupane Huh... This is 4 days overdue. Who can take care of this?

[JmillsExpensify]

Payment summary:

• Contributor: @suneox $500
• Contributor+: @sobitneupane $500

[JmillsExpensify]

Contributor paid out. @sobitneupane since you're paid via Expensify, I'm going to close this issue, though please fill out the BZ checklist before requesting. Thanks!

[sobitneupane]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:

#38755

• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

#38755 (comment)

• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.

Yes.

• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

#39061 (comment)

[sobitneupane]

Regression Test Proposal

1. Go to any chat in mWeb/Safari
2. Tap on the compose box
3. Type a few lines and tap on expand icon
4. Verify that the compose box resizes properly.

Do we agree 👍 or 👎

[JmillsExpensify]

$500 approved for @sobitneupane.