Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS - Distance - Recent destination list animation is not smooth or seamless #40124

Closed
1 of 6 tasks
lanitochka17 opened this issue Apr 11, 2024 · 8 comments
Closed
1 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 11, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.62-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers):
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

  • There is at least one address in Recent destination list
  1. Launch New Expensify app
  2. Go to FAB > Manual request > Distance
  3. Tap Start
  4. Repeat Step 3 several times

Expected Result:

The Recent destination list should animate the same way it does in the production build

Actual Result:

The Recent destination list animates different in staging build. Sometimes the list pops up from the center, sometimes it slides down from the top and the sliding down animation is not smooth
On production build, the list appears seamlessly without looking awkward

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6445947_1712843899557.staging.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Apr 11, 2024
Copy link

melvin-bot bot commented Apr 11, 2024

Triggered auto assignment to @deetergp (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@deetergp FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@lanitochka17
Copy link
Author

Production:

Bug6445947_1712843899542.prod.mp4

@deetergp
Copy link
Contributor

@neil-marcellini Is this possibly related to #39190?

@ishpaul777
Copy link
Contributor

I think this comes from New arch PR #13767, I remember reporting this one

@WoLewicki @j-piasecki Can you please take a look

@neil-marcellini
Copy link
Contributor

Yeah I think it's what @ishpaul777 said. I really don't see a big problem here though. It looks fine to me. I'm going to remove the blocker label and close the issue. If anyone wants to re-open it we can do that, but I think we have much bigger problems elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants