Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat-In compose box, emojis displayed are cut off in top. #40053

Closed
2 of 6 tasks
lanitochka17 opened this issue Apr 10, 2024 · 8 comments
Closed
2 of 6 tasks

Chat-In compose box, emojis displayed are cut off in top. #40053

lanitochka17 opened this issue Apr 10, 2024 · 8 comments
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 10, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.62
Reproducible in staging?: Y
Reproducible in production?: N
**If this was caught during regression testing, add the test name, ID and link from TestRail:*(https://expensify.testrail.io/index.php?/tests/view/4489664)
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app
  2. Tap on a report
  3. Tap emoji picker and select an emoji(any simileys round shaped select it so issue will be visible easily)

Expected Result:

In compose box, emojis displayed must not cut off in top

Actual Result:

In compose box, emojis displayed are cut off in top

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6445124_1712783270715.all.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to @marcaaron (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

@marcaaron FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@tienifr
Copy link
Contributor

tienifr commented Apr 11, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

In compose box, emojis displayed are cut off in top

What is the root cause of that problem?

We define the fontSize and lineHeight of composer in textInputCompose

style={[styles.textInputCompose, isComposerFullSize ? styles.textInputFullCompose : styles.textInputCollapseCompose]}

In small screen fontSize would be 15px and lineHeight 20px

App/src/styles/index.ts

Lines 2018 to 2021 in 260a7de

fontSize: variables.fontSizeNormal,
borderWidth: 0,
height: 'auto',
lineHeight: variables.lineHeightXLarge,

But we define the fontSize of emoji is 20px and it's not consistency

What changes do you think we should make in order to solve the problem?

In react-native-live-markdown we need to apply getValueUsingPixelRatio(15, 21) (similar to this line) to emoji's fontSize

What alternative solutions did you explore? (Optional)

NA

Result

Screen.Recording.2024-04-11.at.14.27.49.mov

@shubham1206agra
Copy link
Contributor

shubham1206agra commented Apr 11, 2024

@robertKozik @tomekzaw @BartoszGrajdek @Skalakid This is related to Live Markdown.
cc @thienlnam

@Julesssss Julesssss added Daily KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment labels Apr 11, 2024
@Julesssss
Copy link
Contributor

Likely live markdown related, and relatively minor. I'm going to demote from a deploy blocker while we fix this.

@thienlnam
Copy link
Contributor

This is known - we have an existing issue here #39274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants