Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.3.0 #381

Merged
merged 26 commits into from
Jun 29, 2023
Merged

Version 1.3.0 #381

merged 26 commits into from
Jun 29, 2023

Commits on Nov 17, 2022

  1. Fix wcag github action mapbox issues (#337)

    paired with the changes in this [PR](yext/slapshot-reusable-workflows#22) in WCAG workflow, this PR updates the WCAG github action in the repo to pass in the mapbox key. Also updated the wcag test to exclude checking elements coming from mapbox canvas container as any potential violations coming from there is outside of our repo's control.
    
    WCAG github action also run on pull request to feature branch now.
    
    J=SLAP-2458
    TEST=auto
    
    see that WCAG github action now passes
    yen-tt authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    ee60b9f View commit details
    Browse the repository at this point in the history
  2. Deprecate LocationBias component (#338)

    this pr mark LocationBias as deprecated in favor of the new Geolocation component.
    
    I checked if storybook have some feature to inform user that a component is deprecated, there's an open feature request: storybookjs/storybook#9721 for displaying @deprecated props but nothing official yet. I did come across a custom addon: https://storybook.js.org/addons/@etchteam/storybook-addon-status which seems to work quite nicely.
    
    Show "Deprecated" status for location bias stories:
    <img width="782" alt="Screen Shot 2022-11-16 at 4 31 20 PM" src="https://user-images.githubusercontent.com/36055303/202298691-49bd8a5a-9332-4f93-8f42-0a7c408ae052.png">
    
    J=SLAP-2448
    TEST=none
    yen-tt authored Nov 17, 2022
    Configuration menu
    Copy the full SHA
    3748b15 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2022

  1. Fix visual coverage test in Github Actions (#339)

    In addition to the changes in the [workflow PR](yext/slapshot-reusable-workflows#24), this up updates run-tests github action and coverage github action to pass mapbox api key so visual coverage test works as expected.
    
    J=SLAP-2467
    TEST=auto
    
    see that run-tests github action and coverage github action passed -- looked into the logs, no false positive / errors related to visual coverage.
    yen-tt authored Nov 18, 2022
    Configuration menu
    Copy the full SHA
    c7e2d78 View commit details
    Browse the repository at this point in the history
  2. Add Geolocation component (#336)

    This PR adds Geolocation component to the repo, with jest tests and storybook stories.
    
    Note: waiting on product to get SVG design for the default geolocation icon. Edit: Will update in another PR
    
    J=SLAP-2396,SLAP-2397,SLAP-2398
    TEST=manual&auto
    
    - tested manually through test site in Products page
    - jest tests passed and storybook stories display component as expected
    yen-tt authored Nov 18, 2022
    Configuration menu
    Copy the full SHA
    ff5293e View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. Update Geolocation to remove all location fields (#344)

    Update `useGeolocationHandler` so that it replaces all location filters with the new filter. In other words, filters on the `builtin.location`, `builtin.region`, and `address.countryCode` fields are all removed when a new filter is selected via the `Geolocation` component. This matches the behavior of `FilterSearch` and ensures the `State` doesn't end up with multiple location filters applied at the same time, which can have unpredictable results from the backend.
    
    J=SLAP-2495
    TEST=auto
    
    See that the Jest tests still pass even when the mocked state includes other kinds of location filters besides those on `builtin.location`.
    nmanu1 authored Dec 6, 2022
    Configuration menu
    Copy the full SHA
    2ce727e View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. add checks to fail combined-coverage tests after each part (#346)

    Currently tests are failing silently in Github actions. This PR adds checks to combined-coverage.sh script to exit if a test fails. The three tests currently failing on main will now be caught, I created this item to handle them separately, as it will require a change to make react versions to test programmable in reusable workflows
    
    J=SLAP-2459
    TEST=manual
    
    ran actions with an intentional failure (log). Also commented out npm publish from the slap publish command and tested that it makes it passed the check there
    tatimblin authored Dec 12, 2022
    Configuration menu
    Copy the full SHA
    cc65e8b View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. Merge main (v1.1.0) into develop (#348)

    Merge main (v1.1.0) into develop
    nmanu1 authored Dec 15, 2022
    Configuration menu
    Copy the full SHA
    79732b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2022

  1. Use reusable workflow in sync_sites_branch (#349)

    Update the `sync_sites_branch` workflow to use the new reusable workflow.
    
    J=SLAP-2507
    TEST=manual
    
    Test on a forked repo and see that a commit to `main` triggers a merge commit to the `storybook-site` and `test-site` branches.
    nmanu1 authored Dec 21, 2022
    Configuration menu
    Copy the full SHA
    3aeb9be View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. Pin react-collapsed to minor version (#350)

    This PR pins `react-collapsed` to the latest minor version (v3.6.0) that supports React 17. In v3.7.0 and v3.8.0, `react-collapsed` fixed a bug ([Slack thread](https://yext.slack.com/archives/C032CKFARGS/p1671130163844249), [GH issue](roginfarrer/collapsed#103)) that occurs when using it with React 18 by introducing a breaking change where they dropped compatibility with React 16 and 17. v3.7.0+ would break a search experience using collapsible facets with React <18. Since they are not able to support both React 17 and 18 together, it seems preferable to pin to a version that can be used with both, but is a little buggy with React 18, rather than fully functional with React 18, but breaks other React experiences.
    
    J=SLAP-2521
    TEST=manual
    
    See that collapsible facets works as expected on a test-site running on React 17 and that the site running on React 18 still has most functionality, except for the bug described above.
    nmanu1 authored Jan 4, 2023
    Configuration menu
    Copy the full SHA
    cb546c5 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Add compatibility notes to README (#358)

    Update the README to add notes about compatibility with Webpack in response to [this](#357) issue.
    nmanu1 authored Apr 10, 2023
    Configuration menu
    Copy the full SHA
    0583f8e View commit details
    Browse the repository at this point in the history

Commits on May 1, 2023

  1. Create Facets component (#360)

    Create a facets component which renders any facets returned by the search. If any hierarchical facets are returned, they are rendered as standard facets.
    
    J=BACK-2220
    TEST=manual, auto
    
    Manually tested this component on the test site and confirmed it rendered all types of facets. Also added a storybook page and automated tests and confirmed they passed.
    cea2aj authored May 1, 2023
    Configuration menu
    Copy the full SHA
    bbf904b View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Update @yext/search-headless-react Version (#362)

    This change updates @yext/search-headless-react to version 2.2.0-beta.0 which contains the EU endpoints change.
    It also bumps @yext/search-ui-react to version 1.2.0-beta.0.
    
    J=BACK-2270
    TEST=auto,manual
    
    Ran `npm run test`.
    Ran `npx serve .` under test-site/.
    EmilyZhang777 authored May 8, 2023
    Configuration menu
    Copy the full SHA
    96468cd View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Prepare version 1.2.0 (#365)

    Bump the search-headless-react version, add hierarchical facet to storybook
    
    J=BACK-2237
    TEST=manual
    
    Ran storybook locally and confirmed the components worked including the new Facets component
    cea2aj authored May 9, 2023
    Configuration menu
    Copy the full SHA
    4245636 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Add Singular StandardFacet (#370)

    Add Singular StandardFacet
    This change adds a singular StandardFacet that can be used to override facets rendered in Facets.
    EmilyZhang777 authored May 12, 2023
    Configuration menu
    Copy the full SHA
    9597e9a View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. Add Numerical Facet (#372)

    Add Numerical Facet
    This change adds a singular NumericalFacet that can be used to override facets rendered in Facets.
    
    J=BACK-2221
    TEST=auto,manual
    
    Ran npm run test and confirmed all tests pass.
    Manually added a NumericalFacet with Facets on the people's page under test-site/. Confirmed the facet gets overridden correctly.
    EmilyZhang777 authored May 16, 2023
    Configuration menu
    Copy the full SHA
    f936f9b View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Add HierarchicalFacet (#373)

    * Add HierarchicalFacet
    
    This PR includes the following changes:
    - Add support for HierarchicalFacet in Facets.
    - Add unit tests for singular facet components.
    - Add Facets to PeoplePage.
    
    J=BACK-2223
    TEST=auto,manual
    
    Ran unit tests. Manually checked the behavior of Facets on PeoplePage.
    EmilyZhang777 authored May 23, 2023
    Configuration menu
    Copy the full SHA
    e9183f3 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Configuration menu
    Copy the full SHA
    0041b9d View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. Add Facets Level Css Support for FilterGroup (#375)

    * Add Facets Level Css Support for FilterGroup
    
    This change allows users to provide css classes for FilterGroup on the Facets level.
    If same css classes are provided on the singular facet level, the latter will be used.
    
    J=BACK-2306
    TEST=auto,manual
    
    Added a test for this.
    Also manually confirmed the behavior.
    EmilyZhang777 authored May 30, 2023
    Configuration menu
    Copy the full SHA
    98f98e4 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Remove logo searchbar (#376)

    removed logo from search bar and increased height of search field
    
    J=BACK-2305
    
    T=manual
    
    Ran test site locally and also checked with UX team
    saahithjanapati authored Jun 8, 2023
    Configuration menu
    Copy the full SHA
    84306bf View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2023

  1. truncate search autcomplete results and prevent resizing (#378)

    Made long autocomplete results show up on one line, truncated by ellipses. Also stopped search icon and history icon from getting resized along with the search bar
    
    Before: https://drive.google.com/file/d/1L-D8lFfdWw53uBAQ4pU2fxuvtAlOOahj/view?usp=sharing
    After: https://drive.google.com/file/d/15Jd5jZ0yXMoDTWMrOT1VsqspbmV0bePc/view?usp=sharing
    
    J=BACK-2239
    
    TEST=manual
    
    ran on test site and verified with product team
    saahithjanapati authored Jun 13, 2023
    Configuration menu
    Copy the full SHA
    2c63584 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. add support to display richtextv2 and markdown that has been converte…

    …d to HTML (#379)
    
    * add support for rendering RichTextv2 and markdown converted to HTML
    
    J=BACK-2241
    
    TEST=manual
    ran test-site of search-ui-react with entity that had formatted RichTextv2 data and verified that it was rendered properly
    
    ---------
    saahithjanapati authored Jun 28, 2023
    Configuration menu
    Copy the full SHA
    beb792a View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. fix merge conflict

    cea2aj committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    51763af View commit details
    Browse the repository at this point in the history
  2. notices file

    cea2aj committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    b52c016 View commit details
    Browse the repository at this point in the history
  3. fix test site package-lock

    cea2aj committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    ffc1ffb View commit details
    Browse the repository at this point in the history
  4. Merge main (v1.2.1) into develop (#369)

    Merge main (v1.2.1) into develop
    cea2aj authored Jun 29, 2023
    Configuration menu
    Copy the full SHA
    f585cd9 View commit details
    Browse the repository at this point in the history
  5. Prepare version 1.3.0 (#380)

    Update the package version and the versions of the analytics lib and the search-headless-react library
    
    J=BACK-2362
    TEST=manual
    
    Ran the test site locally and configured the analytics for sandbox and the EU. Confirmed the events were fired correctly
    cea2aj authored Jun 29, 2023
    Configuration menu
    Copy the full SHA
    22bc73f View commit details
    Browse the repository at this point in the history