Add Singular StandardFacet #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a singular StandardFacet that can be used to override facets rendered in Facets. J=BACK-2221 TEST=auto,manual Ran `npm run test` and confirmed all tests pass. Manually added a StandardFacet with Facets on the people's page under test-site/. Confirmed the facet gets overridden correctly.
benmcginnis
requested changes
May 11, 2023
benmcginnis
approved these changes
May 11, 2023
benmcginnis
reviewed
May 11, 2023
cea2aj
reviewed
May 12, 2023
| * @public | ||
| */ | ||
| export function StandardFacet(props: StandardFacetProps) { return null; } |
There was a problem hiding this comment.
The general convention in this library is for each public component to be in its own file, along with the props and css classes in that file as well. Is there a reason behind this organization instead?
There was a problem hiding this comment.
I put it here since in the spec, they use <Facets.StandardFacet/>. Let me know what you think!
Merged
cea2aj
added a commit
that referenced
this pull request
Jun 29, 2023
# Version 1.3.0 ### Features - Introduce new Facet components including the new Facets (#360), StandardFacet (#370), NumericalFacet (#375), and HierarchicalFacet (#373) components which support more customizability than the previous Facet components. - Support the new RichTextV2 (Lexical) and Markdown fields which have been converted to HTML as FeaturedSnippetDirectAnswers (#379) - Remove the Yext logo from the search bar (#376) - Deprecate LocationBias (#338) component in favor of the new Geolocation component (#336) ### Bug fixes - Improve the UX of the search bar when long autocomplete text is returned which includes the truncation of long text (#378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a singular StandardFacet that can be used to override facets rendered in Facets.
J=BACK-2221
TEST=auto,manual
Ran
npm run testand confirmed all tests pass.Manually added a StandardFacet with Facets on the people's page under test-site/. Confirmed the facet gets overridden correctly.