Create Facets component #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by the search. If any hierarchical facets are returned, they are rendered as standard facets. J=BACK-2220 TEST=manual,auto Manually tested this component on the test site and confirmed it rendered all types of facets. Also added a storybook page and automated tests and confirmed they passed.
|
Current unit coverage is 89.07922912205568% |
by the search. If any hierarchical facets are returned, they are rendered as standard facets. J=BACK-2220 TEST=manual,auto Manually tested this component on the test site and confirmed it rendered all types of facets. Also added a storybook page and automated tests and confirmed they passed.
| @@ -0,0 +1,5 @@ | |||
| import { DisplayableFacetOption } from '@yext/search-headless-react'; | |||
|
|
|||
| export function getOptionLabelText(option: DisplayableFacetOption) { | |||
There was a problem hiding this comment.
can you add a an example of what this is trying to match?
| <StaticFilters | ||
| fieldId='c_hierarchicalFacet' | ||
| title='Static Hierarchical Facets' | ||
| filterOptions={hierarchicalFilterConfigs} | ||
| /> | ||
| <FilterDivider /> |
There was a problem hiding this comment.
why is this only wrapping StaticFilters and br tag is used on line 73?
There was a problem hiding this comment.
These aren't wrapping StaticFilters and are instead standalone filter dividers. The facets dynamically include dividers where needed, but static filters do not
benmcginnis
approved these changes
Apr 29, 2023
| * | ||
| * @remarks | ||
| * This component is a quick way of getting facets on the page, and it will render standard facets, | ||
| * numerical facets, and hierarchical facets. The {@link StandardFacets}, {@link NumericalFacets}, |
There was a problem hiding this comment.
it won't currently use hierarchical facets right?
There was a problem hiding this comment.
It will render them but as standard facets
Closed
Merged
cea2aj
added a commit
that referenced
this pull request
Jun 29, 2023
# Version 1.3.0 ### Features - Introduce new Facet components including the new Facets (#360), StandardFacet (#370), NumericalFacet (#375), and HierarchicalFacet (#373) components which support more customizability than the previous Facet components. - Support the new RichTextV2 (Lexical) and Markdown fields which have been converted to HTML as FeaturedSnippetDirectAnswers (#379) - Remove the Yext logo from the search bar (#376) - Deprecate LocationBias (#338) component in favor of the new Geolocation component (#336) ### Bug fixes - Improve the UX of the search bar when long autocomplete text is returned which includes the truncation of long text (#378)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a facets component which renders any facets returned by the search. If any hierarchical facets are returned, they are rendered as standard facets.
J=BACK-2220
TEST=manual, auto
Manually tested this component on the test site and confirmed it rendered all types of facets. Also added a storybook page and automated tests and confirmed they passed.