Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to display richtextv2 and markdown that has been converted to HTML #379

Merged
merged 9 commits into from
Jun 28, 2023

Conversation

saahithjanapati
Copy link
Contributor

J=BACK-2241

TEST=manual

ran test-site of search-ui-react with entity that had formatted RichTextv2 data and verified that it was rendered properly

J=BACK-2241

TEST=manual
ran test-site of search-ui-react with entity that had formatted RichTextv2 data and verified that it was rendered properly
@saahithjanapati saahithjanapati requested a review from a team as a code owner June 20, 2023 17:24
@coveralls
Copy link

coveralls commented Jun 20, 2023

Coverage Status

coverage: 85.921% (-0.04%) from 85.961% when pulling c7ac45b on display-converted-richText into 2c63584 on develop.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2023

Current unit coverage is 89.13192071086807%
Current visual coverage is 77.28557964184732%
Current combined coverage is 89.7470950102529%

Copy link
Member

@cea2aj cea2aj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@saahithjanapati saahithjanapati merged commit beb792a into develop Jun 28, 2023
@saahithjanapati saahithjanapati deleted the display-converted-richText branch June 28, 2023 19:19
@cea2aj cea2aj mentioned this pull request Jun 29, 2023
cea2aj added a commit that referenced this pull request Jun 29, 2023
# Version 1.3.0

### Features
- Introduce new Facet components including the new Facets (#360), StandardFacet (#370), NumericalFacet (#375), and HierarchicalFacet (#373) components which support more customizability than the previous Facet components. 
- Support the new RichTextV2 (Lexical) and Markdown fields which have been converted to HTML as FeaturedSnippetDirectAnswers (#379)
- Remove the Yext logo from the search bar (#376)
- Deprecate LocationBias (#338) component in favor of the new Geolocation component (#336)

### Bug fixes
- Improve the UX of the search bar when long autocomplete text is returned which includes the truncation of long text (#378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants