-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wcag github action mapbox issues #337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you know why the coverage check is still failing even though the WCAG check passes? I thought they were related
page, | ||
{ | ||
include: ['#root'], | ||
exclude: ['#root .mapboxgl-canvas-container'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For my own edification, was this line the only change needed to get the WCAG tests passing? If we're ignoring Mapbox, the passing of the MAPBOX_API_KEY
shouldn't really matter, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both the passing of mapbox api key and the change in test-runner is needed to get WCAG test passing. It couldn't properly run checks on mapbox stories because the mapbox component never gets render due to no api key, and that causes errors within play
function and closed the browser/session. With MAPBOX_API_KEY
, the mapbox stories was evaluated correctly, but there are a couple violations within mapbox canvas, which is what the change in test-runner is for.
I did a brief investigation yesterday and it appears to be a separate issue, where the visual coverage script seems to be killing the process after running |
paired with the changes in this [PR](yext/slapshot-reusable-workflows#22) in WCAG workflow, this PR updates the WCAG github action in the repo to pass in the mapbox key. Also updated the wcag test to exclude checking elements coming from mapbox canvas container as any potential violations coming from there is outside of our repo's control. WCAG github action also run on pull request to feature branch now. J=SLAP-2458 TEST=auto see that WCAG github action now passes
paired with the changes in this [PR](yext/slapshot-reusable-workflows#22) in WCAG workflow, this PR updates the WCAG github action in the repo to pass in the mapbox key. Also updated the wcag test to exclude checking elements coming from mapbox canvas container as any potential violations coming from there is outside of our repo's control. WCAG github action also run on pull request to feature branch now. J=SLAP-2458 TEST=auto see that WCAG github action now passes
paired with the changes in this PR in WCAG workflow, this PR updates the WCAG github action in the repo to pass in the mapbox key. Also updated the wcag test to exclude checking elements coming from mapbox canvas container as any potential violations coming from there is outside of our repo's control.
WCAG github action also run on pull request to feature branch now.
J=SLAP-2458
TEST=auto
see that WCAG github action now passes