Update Geolocation to remove all location fields #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current unit coverage is 89.04795991410164% |
yen-tt
reviewed
Dec 5, 2022
yen-tt
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
useGeolocationHandlerso that it replaces all location filters with the new filter. In other words, filters on thebuiltin.location,builtin.region, andaddress.countryCodefields are all removed when a new filter is selected via theGeolocationcomponent. This matches the behavior ofFilterSearchand ensures theStatedoesn't end up with multiple location filters applied at the same time, which can have unpredictable results from the backend.J=SLAP-2495
TEST=auto
See that the Jest tests still pass even when the mocked state includes other kinds of location filters besides those on
builtin.location.