-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc: Update PR template checklist #12
Conversation
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-12--gatsby.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request
|
Co-authored-by: Filipe W. Lima <fwl.ufpe@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
## [Unreleased] | |||
|
|||
### Added | |||
- New items in the `pull_request_template.md` ([#12](https://github.com/vtex-sites/gatsby.store/pull/12)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oooh, good call adding the link! Hadn't noticed GH didn't create the link automatically as it does inside issues and PRs messages. Will do the same moving forward.
😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes! 😃 I will add this to the checklist as well!
|
||
- PR description | ||
- [ ] Updated the Storybook - *if applicable*. | ||
- [ ] Added a label according to the PR goal - `Breaking change`, `Enhancement`, `Bug` or `Chore`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added these 2 missing labels to the repo:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @filipewl!
For some unknown reason, the last commit didn't seem to trigger our WebOps checks on GH... You may need to push an empty commit to trigger a new attempt (e.g. Edit: the new commit has started a new attempt already! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good :)
What's the purpose of this pull request?
Added new items to the pull_request_template.md to help highlight the changes added in the
CHANGELOG.md
and Release Notes.How does it work?
The new items intended to help users and the team identify the changes in
gatsby.store
and keep a pattern in theCHANGELOG.md
update.CHANGELOG.md
at the beginning of its due section. The latest version should comes first.CHANGELOG.md
Breaking change
,Enhancement
,Bug
orChore
.ComponentName
component.useWindowDimensions
hook.How to test it?
Describe the steps with bullet points. Is there any external reference, link, or example?
References
Checklist
You may erase this after checking them all ;)