Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc: Update PR template checklist #12

Merged
merged 8 commits into from
Apr 27, 2022
Merged

Doc: Update PR template checklist #12

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
45c54e4
Doc: Update PR template checklist
mariana-caetano Apr 26, 2022
6e78d15
Update CHANGELOG.md
mariana-caetano Apr 26, 2022
9a67c51
Update pull_request_template.md
mariana-caetano Apr 26, 2022
1ce4b69
Update pull_request_template.md
mariana-caetano Apr 26, 2022
104ab82
Update pull_request_template.md
mariana-caetano Apr 26, 2022
f21678f
Update CHANGELOG.md
mariana-caetano Apr 26, 2022
b5b78fd
Update pull_request_template.md
mariana-caetano Apr 26, 2022
ee782d9
Update pull_request_template.md
mariana-caetano Apr 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Adds Storybook configs (#463)
- Adds vtex search tracking script. With this we will populate TopSearches and Autocomplete indices (#389)
- Add `RegionalizationBar`, `RegionalizationButton` components and integrates it on Mobile and Desktop devices (#424).
- New items in the `pull_request_template.md`
mariana-caetano marked this conversation as resolved.
Show resolved Hide resolved

### Changed

Expand Down
12 changes: 11 additions & 1 deletion pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,14 @@

<em>You may erase this after checking them all ;)</em>

- [] CHANGELOG entry added
- [ ] CHANGELOG entry added.
mariana-caetano marked this conversation as resolved.
Show resolved Hide resolved
- [ ] The latest version was added first in the `CHANGELOG.md`.
- [ ] PR number added in the CHANGELOG entry.
mariana-caetano marked this conversation as resolved.
Show resolved Hide resolved


- PR
- [ ] Label added according to the PR goal - `Breaking change`, `Enhancement`, `Bug` or `Chore`.
- [ ] The component, hook, or pathname is in-between backticks (``) *- If applicable*. E.g.: `ComponentName` component.
- [ ] Function or parameter identified on the PR *- If applicable*. E.g.: `useWindowDimensions` hook.
- [ ] For documentation changes, ping @carolinamenezes or @Mariana-Caetano to review and update the changes.