feat: Adds new tokens to Select #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasfp13
requested review from
filipewl,
eduardoformiga,
renatamottam and
ArthurTriis1
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lucasfp13
added
Features
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit c3068a7
|
Preview is readyThis pull request generated a Preview👀 Preview: https://preview-17--gatsby.preview.vtex.app |
lucasfp13
force-pushed
the
feat/FSSS-257-adds-new-tokens-to-select
branch
from
3b03df1 to
8e55798
Compare
lucasfp13
force-pushed
the
feat/FSSS-257-adds-new-tokens-to-select
branch
from
2559a73 to
c98598a
Compare
hellofanny
reviewed
May 3, 2022
|
Well Done! Can you check please on safari again pls. Maybe the autoprefix is not working on the storybook for me 🤔
|
lucasfp13
force-pushed
the
feat/FSSS-257-adds-new-tokens-to-select
branch
from
2eafca2 to
e3644b8
Compare
lucasfp13
force-pushed
the
feat/FSSS-257-adds-new-tokens-to-select
branch
from
e3644b8 to
4f7e3b7
Compare
lucasfp13
force-pushed
the
feat/FSSS-257-adds-new-tokens-to-select
branch
from
1e1e691 to
eefdf49
Compare
lucasfp13
force-pushed
the
feat/FSSS-257-adds-new-tokens-to-select
branch
from
eefdf49 to
9215b9a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR intends to add new tokens to the
Selectcomponent using the Theming Structure.How does it work?
This PR uses local variables to parameterize the
Selectproperties, then connects these scoped tokens to the global ones.New global tokens:
None.
New local tokens for
Select:Default properties:
--fs-select-heightvar(--fs-spacing-6)--fs-select-min-heightvar(--fs-control-tap-size)--fs-select-paddingvar(--fs-spacing-1) var(--fs-spacing-5) var(--fs-spacing-1) var(--fs-spacing-2)--fs-select-text-colorvar(--fs-color-link)--fs-select-border-radiusvar(--fs-border-radius-default)--fs-select-bkgtransparent--fs-select-bkg-color-focusvar(--fs-color-primary-bkg-light)--fs-select-bkg-color-hovervar(--fs-select-bkg-color-focus)--fs-select-transition-timingvar(--fs-transition-timing)--fs-select-transition-propertyvar(--fs-transition-property)--fs-select-transition-functionvar(--fs-transition-function)--fs-select-label-margin-rightvar(--fs-spacing-1)--fs-select-label-colorvar(--fs-color-text-light)--fs-select-icon-rightvar(--fs-spacing-2)--fs-select-icon-colorvar(--fs-color-link)--fs-select-disabled-colorvar(--fs-color-disabled-text)--fs-select-disabled-opacity1How to test it?
The
Selectcomponent should look just as it was before these changes.Right now, we have an error on Storybook that displays
Selecticon with the wrong style because it needs to have a wrapper to limit the input container. So it will be done in another bug task.Checklist
Added an entry in the
CHANGELOG.mdat the beginning of its due section. The latest version should come first.Added the PR number with the PR link at the entry in the
CHANGELOG.md. E.g., New items in thepull_request_template.md(#12)PR description
Updated the Storybook - if applicable.
Added a label according to the PR goal -
Breaking change,Enhancement,BugorChore.Added the component, hook, or pathname in-between backticks (``) - If applicable. E.g.,
ComponentNamecomponent.