fix: Transfers responsibility of InputText's main attributes and callbacks to the renderer
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-1309954--gatsby.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 1309954
|
eduardoformiga
added a commit
that referenced
this pull request
Jul 11, 2022
* Feat: Adds tokens to `ProductGrid` (#144) * Fixes Best Practices section * Creates `ProductGrid` tokens * Creates ProductGrid doc Co-Authored-By: Eduardo Formiga <eduardo.formiga@gmail.com> * Updates Changelog * Fixes `ProductGrid` description typo Co-authored-by: Lucas Feijó <lucas.portela@vtex.com.br> * Hides props that are not working for now * Improves BestPractices descriptions Co-authored-by: Eduardo Formiga <eduardo.formiga@gmail.com> Co-authored-by: Lucas Feijó <lucas.portela@vtex.com.br> * Update Changelog * Adds `LocationProvider` on `ProductGrid` story Co-authored-by: Eduardo Formiga <eduardo.formiga@gmail.com> Co-authored-by: Lucas Feijó <lucas.portela@vtex.com.br>
lucasfp13
force-pushed
the
fix/input-text-component
branch
from
d7faa69 to
5f4ee10
Compare
lucasfp13
force-pushed
the
fix/input-text-component
branch
from
5f4ee10 to
5dc3433
Compare
lucasfp13
force-pushed
the
fix/input-text-component
branch
from
6ae1166 to
661cd2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR intends to fix the
InputTextby removing some component's local implementation, which should be the responsibility of the parent component that is rendering it.How does it work?
Previously, some main attributes were being defined inside
InputTextcomponent (e.g.onInputandvalue) and by doing this, parent components rendering theInputTexthad limitations using the same attributes.How to test it?
The component should look the same as before. The main difference is the change of the responsibility to implement input's required attributes to the parent.
Checklist
Changelog
CHANGELOG.mdat the beginning of its due section. The latest version should comes first.CHANGELOG.md. E.g., New items in thepull_request_template.md(#12)PR Description
Breaking change,Enhancement,BugorChore.ComponentNamecomponent.useWindowDimensionshook.Documentation