-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Adds tokens to Accordion #126
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Preview is readyThis pull request generated a Preview👀 Preview: https://sfj-3c56c2d--gatsby.preview.vtex.app |
Lighthouse ReportsHere are the Lighthouse reports of this Pull Request📝 Based on commit 3c56c2d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving cuz it looks the same as https://github.com/vtex-sites/nextjs.store/pull/130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 💯
Ported from https://github.com/vtex-sites/nextjs.store/pull/130
What's the purpose of this pull request?
This PR applies the new Theming structure to
Accordion
: new scoped tokens linked to global ones.How does it work?
This PR uses local variables to parameterize the
Accordion
properties, then connects these scoped tokens to the global ones.New local tokens for
Accordion
--fs-accordion-item-border-bottom-width
1px
--fs-accordion-item-border-bottom-color
var(--fs-border-color-light)
--fs-accordion-item-button-padding
var(--fs-spacing-3) 0
--fs-accordion-item-button-color
var(--fs-color-text)
--fs-accordion-item-button-bkg-color
transparent
--fs-accordion-item-button-notebook-padding-right
var(--fs-spacing-4)
--fs-accordion-item-button-notebook-padding-left
var(--fs-accordion-item-button-notebook-padding-right)
--fs-accordion-item-panel-notebook-padding-right
var(--fs-spacing-4)
--fs-accordion-item-panel-notebook-padding-left
var(--fs-accordion-item-panel-notebook-padding-right)
How to test it?
Accordion
component and its related components should look just as it was before these changes.Checklist
You may erase this after checking them all ;)
Changelog
CHANGELOG.md
at the beginning of its due section. The latest version should comes first.CHANGELOG.md
. E.g., New items in thepull_request_template.md
(#12)PR Description
Breaking change
,Enhancement
,Bug
orChore
.ComponentName
component.useWindowDimensions
hook.Documentation