Fix: scrollTo not working on Safari 15.4 #121
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported from https://github.com/vtex-sites/nextjs.store/pull/132
What's the purpose of this pull request?
This PR attempts to fix two issues:
scroll-behavior
not working on Safari 15.4 when usingscrollTop
: https://developer.apple.com/forums/thread/703294How does it work?
This issue could also be fixed g the
scroll-behavior: smooth
property. But after aligning with the design team, we favor the workaround approach with a smooth's effect. We should keep an eye out for safari updates and remove them when the native approach is available.Increased a little the threshold, but it won't work for all the cases. It needs further improvements and should be tackled at another moment.
How to test it?
References
Changelog
CHANGELOG.md
at the beginning of its due section. The latest version should comes first.CHANGELOG.md
. E.g., New items in thepull_request_template.md
(#12)PR Description
Breaking change
,Enhancement
,Bug
orChore
.ComponentName
component.useWindowDimensions
hook.Documentation