fix(types): make parameters non-nullable for Playwright options

[apple-yagi]

Description

Currently, when selecting Playwright as the provider, type completion for the options parameter of the click method from @vitest/browser/context's userEvent is not working. This is because when fetching the types for Playwright's options, the possibility of undefined is not eliminated, resulting in a missing interface type. Therefore, I have wrapped it with NonNullable to remove the potential for undefined, which fixes the issue so that type completion now works.

before

after

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

• It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
• Ideally, include a test that fails without this PR but passes with it.
• Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

• Run the tests with pnpm test:ci.

Documentation

• If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

• Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

[netlify]

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	7b7fa53
🔍 Latest deploy log	https://app.netlify.com/sites/vitest-dev/deploys/674ad149aa88230008e7e3ea
😎 Deploy Preview	https://deploy-preview-6989--vitest-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[apple-yagi]

ref:

vitest/packages/browser/src/node/commands/click.ts

Line 21 in 1fa16f9

await browser.$(selector).click(options as any)

[hi-ogawa]

Thanks for the PR 👋

The fix seems right but can you provide a reproduction to better understand the issue?

For me locally, I get an error like this in this reproduction https://github.com/hi-ogawa/reproductions/tree/main/vitest-browser-playwright-types,

screenshot1

but the error somehow went away and I get a correct completion once I added a proper tsconfig.json:

screenshot2

[apple-yagi]

@hi-ogawa Thank you for your reply!

I have a question: what are the settings of the tsconfig.json you added? I suspect that the noUncheckedIndexedAccess option might be the cause.

[hi-ogawa]

Oh, that's a good point. I didn't even have strict: true 😅 After adding that I get the error like screenshot1.

I'm adding dts test in #6995 with skipLibCheck: false and that shows an error too now. We'll merge your PR first. Thanks for the contribution!