feat(coverage): thresholds to support maximum uncovered items
#7061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match Jest's API for coverage thresholds, treating positive numbers as percentage thresholds (`lines: X` means X% of lines must be covered) and negative numbers as absolute thresholds (`lines: -X` means no more than X lines may be uncovered).
When using absolute coverage thresholds (configured using negative numbers) with the `autoUpdate` flag, set the new thresholds based on the reported number of uncovered entities. If there are no uncovered entities, set the threshold to 100%.
Remove links to Istanbul docs since those docs only talk about percentage thresholds (and they don't contain any additional information that isn't already in the vitest docs).
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
I see one test failure in CI that appears to be an unrelated test: |
AriPerkkio
changed the title
thresholds to support maximum uncovered items
4 tasks
AriPerkkio
requested changes
Dec 13, 2024
Co-authored-by: Ari Perkkiö <ari.perkkio@gmail.com>
AriPerkkio
reviewed
Dec 17, 2024
Co-authored-by: Ari Perkkiö <ari.perkkio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #7056
Match Jest's API for coverage thresholds, treating a positive number as the minimum covered percentage (
lines: 90means 90% of lines must be covered) and a negative number as the maximum uncovered count (lines: -10means no more than 10 lines may be uncovered).When using negative coverage thresholds with the
autoUpdateflag, set the new thresholds based on the reported number of uncovered entities. If there are no uncovered entities, set the threshold to 100%.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.