-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow multi-browser configuration #6975
Merged
sheremet-va
merged 53 commits into
vitest-dev:main
from
sheremet-va:feat/multi-browser-config
Dec 19, 2024
Merged
feat: allow multi-browser configuration #6975
sheremet-va
merged 53 commits into
vitest-dev:main
from
sheremet-va:feat/multi-browser-config
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
6 tasks
sheremet-va
force-pushed
the
feat/multi-browser-config
branch
2 times, most recently
from
December 4, 2024 17:04
8e54cff
to
227094e
Compare
sheremet-va
force-pushed
the
feat/multi-browser-config
branch
from
December 9, 2024 13:42
30ba4b6
to
3cc6dc5
Compare
hi-ogawa
reviewed
Dec 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! I think I understood the idea and it makes sense to me 👍
I didn't check docs and there are some TODOs, but I guess those can be checked later.
Feel free to proceed if you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #5963
Closes #7017
The general idea is to inject new projects if
instances
are defined that inherit the same config and vite serverWith this PR,
browser.name
andbrowser.providerOptions
are deprecated. Useinstances
instead:The main performance optimization here instead of using different projects is that we can reuse the same server and keep the cache.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.