Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support Vite v6 in mocker package #7058

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

cexbrayat
Copy link
Contributor

Description

This avoids warnings like:

└─┬ vitest 3.0.0-beta.2
  └─┬ @vitest/mocker 3.0.0-beta.2
    └── ✕ unmet peer vite@^5.0.0: found 6.0.3

when using v3 beta with Vite v6 and pnpm.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c02235d
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/6758586e5cffe80008c822e6
😎 Deploy Preview https://deploy-preview-7058--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

This avoids warnings like:

```
└─┬ vitest 3.0.0-beta.2
  └─┬ @vitest/mocker 3.0.0-beta.2
    └── ✕ unmet peer vite@^5.0.0: found 6.0.3
```
@cexbrayat cexbrayat changed the title feat: support Vite v6 in mocker/ui packages feat: support Vite v6 in mocker package Dec 10, 2024
@sheremet-va
Copy link
Member

Thank you!

@sheremet-va sheremet-va merged commit 96f47d3 into vitest-dev:main Dec 10, 2024
17 checks passed
@dubzzz
Copy link
Contributor

dubzzz commented Jan 6, 2025

Is there a plan to release this change within a 2.x version? (if vite 6.x is compatible with 2.x)

@sheremet-va
Copy link
Member

Is there a plan to release this change within a 2.x version? (if vite 6.x is compatible with 2.x)

Vitest 2 will not support Vite 6, that’s the whole reason we are releasing Vitest 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants